[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5619: Fix double memory allocation during operator setup

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #5619:
URL: https://github.com/apache/incubator-pinot/pull/5619#issuecomment-649736123


   Good finding!
   In order to fix this, I would recommend replacing `_dataBlockMap` with `Map<String, DataSourceMetadata>` or Map<String, FieldSpec>`. Setting blocks in operator constructor is not correct.
   
   Besides, the real root cause of this issue is allocating direct memory within reader context without freeing it explicitly. There is no guarantee when the direct memory can be released. We need to figure out a way to free the memory explicitly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org