You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/01/12 09:31:42 UTC
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/623
Pass defaultValue parameter to z.select
### What is this PR for?
This PR is to fix the `z.select()` defaultValue
### What type of PR is it?
Bug Fix
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-581
### How should this be tested?
If you run:
```
val selected = z.select("formName", "option1", Seq(("option1", "option1DisplayName"), ("option2", "option2DisplayName")))
println(selected)
```
you should see: `res27: Object = option1`
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/selectDisplayFormDefaultValue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit 15b4199ba15f662ddbfc272a09825ab331ba65e8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-01-12T08:27:13Z
Pass defaultValue parameter to z.select
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/623#issuecomment-171219267
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/623#issuecomment-171168297
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/623#issuecomment-171128177
READY!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/623
Pass defaultValue parameter to z.select
### What is this PR for?
This PR is to fix the `z.select()` defaultValue
### What type of PR is it?
Bug Fix
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-581
### How should this be tested?
If you run:
```
val selected = z.select("formName", "option1", Seq(("option1", "option1DisplayName"), ("option2", "option2DisplayName")))
println(selected)
```
you should see: `res27: Object = option1`
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/selectDisplayFormDefaultValue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit 15b4199ba15f662ddbfc272a09825ab331ba65e8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-01-12T08:27:13Z
Pass defaultValue parameter to z.select
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Pass defaultValue parameter to z....
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/623#issuecomment-171120829
Triggering CI again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---