You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Samarth Jain (JIRA)" <ji...@apache.org> on 2017/06/29 21:27:00 UTC

[jira] [Updated] (PHOENIX-3938) Don't throw IOException out of coprocessor hooks

     [ https://issues.apache.org/jira/browse/PHOENIX-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Samarth Jain updated PHOENIX-3938:
----------------------------------
    Attachment: PHOENIX-3938_nowhitespacediff.patch

No whitespace diff patch. [~jamestaylor] or [~tdsilva], please review.

I am not 100% sure about how to handle InterruptedException in various hooks in UngroupedAggregateRegionObserver. For now, I followed the same pattern as before to throw it back as an IOException but I am not sure. [~rajeshbabu] or [~enis] - do you have any insights on how should these InterruptedExceptions be handled in UngroupedAggregateRegionObserver? 

> Don't throw IOException out of coprocessor hooks
> ------------------------------------------------
>
>                 Key: PHOENIX-3938
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3938
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3938_nowhitespacediff.patch
>
>
> We shouldn't wrap and throw exceptions as an IOException from coprocessor hooks since that'll trigger the retry logic which just delays throwing the exception back to the client. Instead, we should wrap in a DoNotRetryIOException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)