You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "pefernan (via GitHub)" <gi...@apache.org> on 2024/04/02 08:21:43 UTC
[PR] incubator-kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
pefernan opened a new pull request, #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223
Closes https://github.com/apache/incubator-kie-issues/issues/966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223#discussion_r1548238065
##########
packages/maven-base/pom.xml:
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+>
+
+ <groupId>org.kie.tools</groupId>
+ <artifactId>maven-base</artifactId>
+ <version>${revision}</version>
+
+ <modelVersion>4.0.0</modelVersion>
+ <name>KIE Tools :: Maven Base</name>
+
+ <packaging>pom</packaging>
+
+ <properties>
+ <compiler-plugin.version>3.12.1</compiler-plugin.version>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <version.resources.plugin>3.2.0</version.resources.plugin>
+ <version.flatten.plugin>1.3.0</version.flatten.plugin>
+ <quarkus.platform.version>3.2.9.Final</quarkus.platform.version>
+ <version.org.kie.kogito>999-20240218-SNAPSHOT</version.org.kie.kogito>
Review Comment:
Instead of hard coding the dependencies version here, I think we should be reusing the values from `env`. There's other packages doing this.. See https://github.com/apache/incubator-kie-tools/blob/main/packages/dev-deployment-kogito-quarkus-blank-app/install.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223#issuecomment-2035307718
@pefernan I see there are changes done to `runtime-tools-process-dev-ui-webapp` and `runtime-tools-process-webapp-components` that seem unrelated... do you mind adding them to the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223#issuecomment-2035662997
@pefernan I just remembered something. For Maven packages to successfully be installed and not require the -D properties we require during the build, we need to run a Maven plugin called `flatten-maven-plugin`. The configuration is standard, and I think you can just configure it at the `maven-base` package, in the `<build><plugins>`. Every Maven package on `kie-tools` need to run it so that the published `pom.xml` doesn't depend on the build properties we pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#966: Move the BPMN Quarkus Dev UI package from `kogito-apps` to `kie-tools` [incubator-kie-tools]
Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on PR #2223:
URL: https://github.com/apache/incubator-kie-tools/pull/2223#issuecomment-2036704530
> @pefernan I just remembered something. For Maven packages to successfully be installed and not require the -D properties we require during the build, we need to run a Maven plugin called `flatten-maven-plugin`. The configuration is standard, and I think you can just configure it at the `maven-base` package, in the `<build><plugins>`. Every Maven package on `kie-tools` need to run it so that the published `pom.xml` doesn't depend on the build properties we pass.
right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org