[GitHub] [spark] vanzin commented on a change in pull request #25629: [SPARK-28931][CORE][TESTS] Fix couple of bugs in FsHistoryProviderSuite

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #25629: [SPARK-28931][CORE][TESTS] Fix couple of bugs in FsHistoryProviderSuite
URL: https://github.com/apache/spark/pull/25629#discussion_r319591619
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ##########
 @@ -1256,12 +1257,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
     val cstream = codec.map(_.compressedOutputStream(fstream)).getOrElse(fstream)
     val bstream = new BufferedOutputStream(cstream)
     if (isNewFormat) {
 
 Review comment:
   We don't support the old log format anymore, so you could actually remove this parameter since you're here...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org