You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/19 09:26:32 UTC
[jira] [Commented] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172090#comment-13172090 ]
jiraposter@reviews.apache.org commented on GIRAPH-106:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/
-----------------------------------------------------------
Review request for giraph.
Summary
-------
Added method assignMessagesToVertex() to bypass the package-private access for setMessages(). Cleaned up some missed formatting for GIRAPH-80 as well.
This addresses bug GIRAPH-106.
https://issues.apache.org/jira/browse/GIRAPH-106
Diffs
-----
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java 1220642
Diff: https://reviews.apache.org/r/3255/diff
Testing
-------
Passed local unittests.
Thanks,
Avery
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira