You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 10:39:06 UTC
[GitHub] [airflow] Greetlist opened a new pull request #19640: clear task's next_method and next_kwargs when clear the task
Greetlist opened a new pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
clear task's next_method and next_kwargs when clear the task
Signed-off-by: Greetlist <45...@qq.com>
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #19120
related: #19612
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-1020675473
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-990119818
The description says this closes #19120 but that issue is already closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-973677298
It seems stuck at **Tests/ Wait for CI images(pull_request)**, What can I do now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-1073379888
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-1020675473
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-984418595
There are some failing checks which caused by AssertionError.
tests/jobs/test_scheduler_job.py
```
TestSchedulerJob::test_max_active_runs_creation_phasing():
"""
Test that when creating runs once max_active_runs is reached that the runs come in the right order
without gaps
"""
...
...
expected_execution_dates = [datetime.datetime(2016, 1, d, tzinfo=timezone.utc) for d in range(1, 6)]
dagrun_execution_dates = [
dr.execution_date for dr in session.query(DagRun).order_by(DagRun.execution_date).all()
]
assert dagrun_execution_dates == expected_execution_dates #AssertionError
```
I check the error info, is the **dagrun_execution_dates** list missing some elements?I have no idea what goes wrong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#discussion_r791450619
##########
File path: airflow/models/taskinstance.py
##########
@@ -204,6 +204,7 @@ def clear_task_instances(
ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
ti.state = State.NONE
ti.external_executor_id = None
+ ti.clear_next_method_args()
Review comment:
Some additional asserts in `TestClearTasks` should be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-971459843
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-981539637
I merged the latest upstream `main` to your branch so this can run against the latest CI configuration. There are some recent improvements that may help this pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-1028619807
Can I reopen this PR or start a new PR for it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#discussion_r766005099
##########
File path: airflow/models/taskinstance.py
##########
@@ -204,6 +204,7 @@ def clear_task_instances(
ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
ti.state = State.NONE
ti.external_executor_id = None
+ ti.clear_next_method_args()
Review comment:
Should we add some sort of unit test for it?
suggestions @uranusjr @dstandish ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-973792545
Let it try again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Greetlist closed pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
Greetlist closed pull request #19640:
URL: https://github.com/apache/airflow/pull/19640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#discussion_r791450619
##########
File path: airflow/models/taskinstance.py
##########
@@ -204,6 +204,7 @@ def clear_task_instances(
ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
ti.state = State.NONE
ti.external_executor_id = None
+ ti.clear_next_method_args()
Review comment:
Some additional asserts in `TestClearTasks` should be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19640:
URL: https://github.com/apache/airflow/pull/19640#issuecomment-971450123
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org