You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/15 09:39:10 UTC

[GitHub] [inlong] gong opened a new pull request, #5550: [INLONG-5462][Sort] Add audit for HBase load node and fix MySqlSource set inlong metric error

gong opened a new pull request, #5550:
URL: https://github.com/apache/inlong/pull/5550

   ### Prepare a Pull Request
   
   - [INLONG-5462][Sort] Add audit for HBase load node and fix MySqlSource set inlong metric error
   
   - Fixes #5462
   
   ### Motivation
   
   Add audit for HBase load node and fix MySqlSource set inlong metric error
   
   ### Modifications
   
   * Add inlong.audit option for hbase load node
   * Add inlong audit computing for hbase load node
   * Fix mysql extract node set inlong metric error
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap commented on a diff in pull request #5550: [INLONG-5462][Sort] Add audit for HBase load node and fix MySqlSource set inlong metric error

Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5550:
URL: https://github.com/apache/inlong/pull/5550#discussion_r946299488


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -103,15 +104,17 @@ public HBaseSinkFunction(
             long bufferFlushMaxSizeInBytes,
             long bufferFlushMaxMutations,
             long bufferFlushIntervalMillis,
-            String inLongMetric) {
+            String inLongMetric,
+            String inlongAudit) {
         this.hTableName = hTableName;
         // Configuration is not serializable
         this.serializedConfig = HBaseConfigurationUtil.serializeConfiguration(conf);
         this.mutationConverter = mutationConverter;
         this.bufferFlushMaxSizeInBytes = bufferFlushMaxSizeInBytes;
         this.bufferFlushMaxMutations = bufferFlushMaxMutations;
         this.bufferFlushIntervalMillis = bufferFlushIntervalMillis;
-        this.inLongMetric = inLongMetric;
+        this.inlongMetric = inLongMetric;

Review Comment:
   inlongMetric



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #5550: [INLONG-5463][Sort] Add audit for HBase load node and fix MySqlSource set inlong metric error

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5550:
URL: https://github.com/apache/inlong/pull/5550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] gong commented on a diff in pull request #5550: [INLONG-5462][Sort] Add audit for HBase load node and fix MySqlSource set inlong metric error

Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5550:
URL: https://github.com/apache/inlong/pull/5550#discussion_r946302016


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -103,15 +104,17 @@ public HBaseSinkFunction(
             long bufferFlushMaxSizeInBytes,
             long bufferFlushMaxMutations,
             long bufferFlushIntervalMillis,
-            String inLongMetric) {
+            String inLongMetric,
+            String inlongAudit) {
         this.hTableName = hTableName;
         // Configuration is not serializable
         this.serializedConfig = HBaseConfigurationUtil.serializeConfiguration(conf);
         this.mutationConverter = mutationConverter;
         this.bufferFlushMaxSizeInBytes = bufferFlushMaxSizeInBytes;
         this.bufferFlushMaxMutations = bufferFlushMaxMutations;
         this.bufferFlushIntervalMillis = bufferFlushIntervalMillis;
-        this.inLongMetric = inLongMetric;
+        this.inlongMetric = inLongMetric;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org