RE: svn commit: r1031035 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: hwright@apache.org [mailto:hwright@apache.org]
> Sent: donderdag 4 november 2010 16:31
> To: commits@subversion.apache.org
> Subject: svn commit: r1031035 -
> /subversion/trunk/subversion/libsvn_wc/wc_db.c
> 
> Author: hwright
> Date: Thu Nov  4 15:31:14 2010
> New Revision: 1031035
> 
> URL: http://svn.apache.org/viewvc?rev=1031035&view=rev
> Log:
> Rewrite svn_wc__db_read_kind() to efficiently fetch the node kind,
> rather than
> go through read_info() to do so.

Does this still provide a measureable performance improvement these days?

We used to fetch BASE, WORKING and ACTUAL as separate statements some time ago, but a _read_info() asking for just status should only fetch this row now.

	Bert 

Re: svn commit: r1031035 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

On Thu, Nov 4, 2010 at 10:54 AM, Bert Huijben <be...@qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: hwright@apache.org [mailto:hwright@apache.org]
>> Sent: donderdag 4 november 2010 16:31
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1031035 -
>> /subversion/trunk/subversion/libsvn_wc/wc_db.c
>>
>> Author: hwright
>> Date: Thu Nov  4 15:31:14 2010
>> New Revision: 1031035
>>
>> URL: http://svn.apache.org/viewvc?rev=1031035&view=rev
>> Log:
>> Rewrite svn_wc__db_read_kind() to efficiently fetch the node kind,
>> rather than
>> go through read_info() to do so.
>
> Does this still provide a measureable performance improvement these days?
>
> We used to fetch BASE, WORKING and ACTUAL as separate statements some time ago, but a _read_info() asking for just status should only fetch this row now.

I was mainly focused on removing all the conditionals in read_info()
function.  I haven't measured any performance improvements or lack
thereof.  (Though I suspect that all the conditionals do throw off
branch predictors.)

-Hyrum