You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/07 15:07:56 UTC

[GitHub] [iceberg] rajarshisarkar commented on a diff in pull request #4941: Core: Use Table Partitioning sort with manual Sort Order in Rewrite Data Files

rajarshisarkar commented on code in PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#discussion_r915986927


##########
core/src/main/java/org/apache/iceberg/actions/SortStrategy.java:
##########
@@ -48,7 +49,7 @@ public abstract class SortStrategy extends BinPackStrategy {
    * @return this for method chaining
    */
   public SortStrategy sortOrder(SortOrder order) {
-    this.sortOrder = order;

Review Comment:
   @rdblue, I have added the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org