You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2024/07/31 12:24:29 UTC
[PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
HappenLee opened a new pull request, #38617:
URL: https://github.com/apache/doris/pull/38617
## Proposed changes
fix ubsan use int32_t pointer access bool value is ub:
```
load of misaligned address 0x7fff94267926 for type 'const int32_t', which requires 4 byte alignment
```
result is error
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #38617:
URL: https://github.com/apache/doris/pull/38617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260479056
<details>
<summary>ClickBench: <b>Total hot run time: 31.05 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 51e03bc1d6dd643da0a27eef8046918795e8603e, data reload: false
query1 0.05 0.03 0.03
query2 0.08 0.04 0.04
query3 0.22 0.04 0.04
query4 1.69 0.06 0.06
query5 0.49 0.48 0.49
query6 1.15 0.72 0.71
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.59 0.51 0.50
query10 0.55 0.57 0.56
query11 0.15 0.12 0.12
query12 0.15 0.13 0.13
query13 0.61 0.60 0.60
query14 0.78 0.80 0.78
query15 0.91 0.86 0.86
query16 0.34 0.35 0.36
query17 0.97 1.00 1.00
query18 0.22 0.21 0.22
query19 1.83 1.73 1.73
query20 0.01 0.01 0.01
query21 15.40 0.80 0.66
query22 3.49 5.82 2.24
query23 17.93 1.35 1.33
query24 2.19 0.22 0.21
query25 0.19 0.08 0.08
query26 0.31 0.22 0.21
query27 0.46 0.23 0.23
query28 13.18 1.00 0.99
query29 12.54 3.33 3.32
query30 0.26 0.06 0.05
query31 2.86 0.41 0.41
query32 3.24 0.48 0.49
query33 2.93 2.96 2.96
query34 15.46 4.28 4.25
query35 4.34 4.33 4.31
query36 0.67 0.48 0.47
query37 0.19 0.17 0.16
query38 0.17 0.16 0.15
query39 0.04 0.04 0.04
query40 0.16 0.13 0.13
query41 0.10 0.05 0.04
query42 0.05 0.04 0.04
query43 0.06 0.03 0.04
Total cold run time: 107.08 s
Total hot run time: 31.05 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2261863959
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2261825942
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260400097
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260467884
<details>
<summary>TPC-DS: <b>Total hot run time: 170845 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 51e03bc1d6dd643da0a27eef8046918795e8603e, data reload: false
query1 901 372 376 372
query2 6476 1726 1708 1708
query3 6684 212 223 212
query4 20257 17308 17299 17299
query5 4310 521 527 521
query6 278 182 173 173
query7 4600 305 299 299
query8 273 218 198 198
query9 8529 2393 2392 2392
query10 433 281 274 274
query11 10431 10112 10071 10071
query12 147 91 85 85
query13 1634 379 383 379
query14 9810 8370 8637 8370
query15 201 165 167 165
query16 7053 474 455 455
query17 968 562 556 556
query18 1818 300 291 291
query19 198 151 153 151
query20 92 91 87 87
query21 214 103 101 101
query22 4208 4213 4050 4050
query23 33760 32794 32947 32794
query24 10387 3047 3004 3004
query25 701 403 397 397
query26 1721 161 153 153
query27 2878 282 281 281
query28 6789 1985 1987 1985
query29 1281 445 436 436
query30 291 154 151 151
query31 952 769 772 769
query32 103 60 65 60
query33 713 327 332 327
query34 919 476 488 476
query35 842 734 745 734
query36 1014 880 872 872
query37 292 82 81 81
query38 2898 2773 2768 2768
query39 863 823 809 809
query40 285 116 117 116
query41 52 48 48 48
query42 136 105 106 105
query43 477 449 438 438
query44 1210 741 742 741
query45 210 181 183 181
query46 1092 822 789 789
query47 1767 1709 1734 1709
query48 371 295 302 295
query49 1209 437 435 435
query50 909 438 439 438
query51 6736 6737 6662 6662
query52 102 90 103 90
query53 258 190 184 184
query54 650 474 466 466
query55 82 80 78 78
query56 279 274 275 274
query57 1207 1059 1023 1023
query58 282 271 274 271
query59 2524 2341 2513 2341
query60 298 270 268 268
query61 113 97 97 97
query62 928 660 665 660
query63 212 191 183 183
query64 5918 1887 1907 1887
query65 3155 3081 3085 3081
query66 1426 345 335 335
query67 15441 14899 14849 14849
query68 5857 580 571 571
query69 720 398 313 313
query70 1143 1074 1056 1056
query71 465 279 278 278
query72 7879 2710 2495 2495
query73 904 328 331 328
query74 6075 5630 5661 5630
query75 3843 2758 2716 2716
query76 3457 1389 1423 1389
query77 700 344 336 336
query78 9473 8953 8931 8931
query79 3172 558 538 538
query80 2548 521 510 510
query81 576 228 228 228
query82 1435 142 129 129
query83 312 171 174 171
query84 271 78 83 78
query85 1607 351 312 312
query86 478 313 288 288
query87 3320 3151 3146 3146
query88 3819 2419 2434 2419
query89 407 289 291 289
query90 1905 292 219 219
query91 135 102 102 102
query92 63 53 52 52
query93 3453 620 613 613
query94 913 302 340 302
query95 390 275 274 274
query96 613 282 281 281
query97 3210 3014 3083 3014
query98 225 205 202 202
query99 1620 1328 1285 1285
Total cold run time: 274236 ms
Total hot run time: 170845 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260446269
<details>
<summary>TPC-H: <b>Total hot run time: 42129 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 51e03bc1d6dd643da0a27eef8046918795e8603e, data reload: false
------ Round 1 ----------------------------------
q1 18132 4217 4256 4217
q2 2967 217 223 217
q3 11862 1400 1423 1400
q4 10613 842 931 842
q5 7770 3057 2986 2986
q6 222 141 135 135
q7 1043 624 611 611
q8 9426 1851 1970 1851
q9 8578 6642 6646 6642
q10 8728 3846 3858 3846
q11 431 259 258 258
q12 417 230 232 230
q13 17777 2953 2978 2953
q14 269 241 235 235
q15 528 491 490 490
q16 495 399 389 389
q17 982 930 926 926
q18 8031 7357 7316 7316
q19 1395 1217 1204 1204
q20 579 328 348 328
q21 5282 4796 4758 4758
q22 360 296 295 295
Total cold run time: 115887 ms
Total hot run time: 42129 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4072 4009 4009 4009
q2 323 226 220 220
q3 3008 3014 2945 2945
q4 1889 1917 1894 1894
q5 5225 5223 5222 5222
q6 216 131 131 131
q7 2063 1710 1676 1676
q8 3240 3319 3299 3299
q9 8309 8315 8350 8315
q10 3761 3836 3852 3836
q11 548 450 460 450
q12 738 584 533 533
q13 10934 2943 2971 2943
q14 294 257 255 255
q15 520 481 485 481
q16 443 409 403 403
q17 1759 1703 1711 1703
q18 7879 7355 7236 7236
q19 1770 1688 1674 1674
q20 1989 1756 1740 1740
q21 5500 5148 5143 5143
q22 517 459 455 455
Total cold run time: 64997 ms
Total hot run time: 54563 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260412423
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](fix) fix ubsan use int32_t pointer access bool value [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #38617:
URL: https://github.com/apache/doris/pull/38617#issuecomment-2260401335
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org