You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/04/02 15:12:13 UTC
[jira] Commented: (QPID-1764) Create Abstract base class to perform
new reference counting for TransactionLog
[ https://issues.apache.org/jira/browse/QPID-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694998#action_12694998 ]
Martin Ritchie commented on QPID-1764:
--------------------------------------
The changes committed do allow TestableMemoryMessageStore to function correctly, this class needs updated to access and record reference counts.
The following tests need to be checked as the current TMMS returning an empty set for reference counts still allows the tests to succeed, the following tests use TMMS and so need to be checked:
TxAckTest
AMQQueueMBeanTest
AckTest
persistentMessageTest
SimpleAMQQueueTest
ACLManagerTest
FirewallPluginTest
TestReferenceCounting
TestApplicationRegisty
-Used by:
ApplicationRegistryShutdownTest
InternalBrokerBaseCase
- Use By:
AcknowledgeTest
MessageStoreShutdownTest
QueueBrowserUsesNoAckTest
> Create Abstract base class to perform new reference counting for TransactionLog
> -------------------------------------------------------------------------------
>
> Key: QPID-1764
> URL: https://issues.apache.org/jira/browse/QPID-1764
> Project: Qpid
> Issue Type: Bug
> Components: Performance
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Blocker
> Fix For: 0.5
>
>
> Summary:
> Summary the introduction of the new TransactionLog interface over the old MessageStore has resulted in each of the old Stores performing their own reference counting. As a result they all suffer from:
> a) Being different implementations
> b) Not being fully tested by existing test frameworks.
> By creating a single reference counting TransactionLog base class that delegates the simple storage and retreival tasks to the underlying Stores the stores can be simpler and the testing more complete.
> Current testing has already shown that performance has knocked 5% by the MemoryMessageStore's implementation of reference counting when it should not need to be doing any reference counting.
> This was brought up during the FtD Code review
> http://cwiki.apache.org/confluence/display/qpid/FtD+Code+Review+Notes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org