[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2604: Moves to Armeria 0.86

[GitBox <gi...@apache.org>]

adriancole commented on a change in pull request #2604: Moves to Armeria 0.86
URL: https://github.com/apache/incubator-zipkin/pull/2604#discussion_r285332700
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -213,7 +214,7 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage
     String encoding = request.headers().get(HttpHeaderNames.CONTENT_ENCODING);
     HttpData content = request.content();
     if (!content.isEmpty() && encoding != null && encoding.contains("gzip")) {
-      content = GZIP_DECODER_FACTORY.newDecoder().decode(content);
+      content = GZIP_DECODER_FACTORY.newDecoder(ByteBufAllocator.DEFAULT).decode(content);
 
 Review comment:
   @anuraaga @trustin this was a guess. Is it correct to do this or is there a request-specific means to choose the most relevant byte buff allocator?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services