You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/20 04:22:49 UTC

[PR] fix(dlq): scope the group search to the selected instance [rocketmq-dashboard]

Frun1na opened a new pull request, #4577:
URL: https://github.com/apache/rocketmq-dashboard/pull/4577

   ### Which Issue(s) This PR Fixes
   
   <!-- Fixes #NNN to be backfilled right after the issue is filed -->
   
   ### Brief Description
   
   On the DLQ page the group search term survives an instance switch. The instance-scoped reset block in `DLQPage` clears the rows, pagination, selection and dialogs, but not `search`, so the first request for the newly selected instance is sent with the previous instance's search term — the page then shows an empty or misleading list for data the user never searched on. The same family of leaks was fixed for the client tables (#4240) and for hidden topic/consumer selections (#4465); this is the DLQ counterpart.
   
   The reset block now also calls `setSearch('')`, so the term can only filter the instance it was typed against. Regression test added: switching instances after searching asserts the next `listDLQGroups` call carries no search term and the input shows the cleared value.
   
   ### How Did You Test This Change?
   
   - Red first: added `clears the search term when the selected instance changes` and confirmed it fails on master@d50ffecc (`listDLQGroups` last called with `('instance-2', 'ord', 1, 20)` instead of `('instance-2', undefined, 1, 20)`).
   - After the fix: `cd web && npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx` → `Test Files 1 passed (1)`, `Tests 21 passed (21)`.
   - `npx eslint src/pages/instance/dlq.tsx src/pages/instance/__tests__/DLQPage.test.tsx` → 0 errors (one pre-existing `react-refresh/only-export-components` warning on an untouched line).
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named `...Test`
   - [ ] New UI text has both Chinese and English entries under `web/src/i18n/` (no UI text changed)
   - [x] Architecture constraints stay green (`mvn test` runs the ArchUnit checks) (frontend-only change)
   - [x] New source files carry the ASF license header (no new source files)
   - [ ] Documentation touched where behaviour changed (README / `docs/` / in-app help) (no behaviour documentation affected)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): scope the group search to the selected instance [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4577:
URL: https://github.com/apache/rocketmq-dashboard/pull/4577#issuecomment-5934656204

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): scope the group search to the selected instance [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4577:
URL: https://github.com/apache/rocketmq-dashboard/pull/4577#issuecomment-6093172078

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): scope the group search to the selected instance [rocketmq-dashboard]

Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #4577:
URL: https://github.com/apache/rocketmq-dashboard/pull/4577#issuecomment-6044075978

   Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): scope the group search to the selected instance [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #4577:
URL: https://github.com/apache/rocketmq-dashboard/pull/4577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org