You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/03 10:59:51 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5342:
[AIRFLOW-4521] Pause dag not load dagbag
ashb commented on a change in pull request #5342: [AIRFLOW-4521] Pause dag not load dagbag
URL: https://github.com/apache/airflow/pull/5342#discussion_r289790918
##########
File path: airflow/models/dag.py
##########
@@ -1519,40 +1519,22 @@ def create_dagrun(self,
conf=conf,
session=session)
- @classmethod
- def _find_dag_ids_including_subdags(cls, dag: DAG):
- from airflow.operators.subdag_operator import SubDagOperator # Avoid circular imports
- dag_ids = [dag.dag_id]
- for task in dag.tasks:
- if isinstance(task, SubDagOperator):
- subdag = task.subdag
- dag_ids.extend(cls._find_dag_ids_including_subdags(subdag))
- return dag_ids
-
- @classmethod
Review comment:
Nice - that feels better too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services