You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/05 21:03:47 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
brusdev opened a new pull request #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595672897
@brusdev will you have the PR today? If so ill hold off the revert, else will revert still, just so it doesnt leave master with the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595559405
@michaelandrepearce, feel free to revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595555227
@jbertram / @brusdev
Guys this is a breaking change as no longer with use core naming enabled the naming patterns match with amqp.
Also anyone filtering on metrics based on existing pattern will break.
Also this merged very quickly for a non critical fix can we please ask for giving others time to review in future.
Can either this revert this or ensure amqp is alinged when amqp core naming is toggled, along with making it feature toggle so that its opt in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595735740
i think we need to address both the issues, to not revert this,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595702996
@brusdev looking at the jira, this implementation requires the client to set client id, which isnt always advisable. To meet the needs of the jira,
other identifying information also be present, e.g. the user + hostname
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on issue #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
brusdev commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595627187
@michaelandrepearce @jbertram I'm going to create a new PR to avoid breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595563450
Will revert in the morning then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on issue #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
brusdev commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595690905
@michaelandrepearce I'm working on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595555227
@jbertram / @brusdev
Guys this is a breaking change as no longer with use core naming enabled the naming patterns match with amqp.
As well but less critical anyone filtering on metrics based on existing pattern will break.
Also this merged very quickly for a non critical fix can we please ask for giving others time to review in future.
Can either this revert this or ensure amqp is alinged when amqp core naming is toggled, along with making it feature toggle so that its opt in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3002:
ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595555227
Guys this is a breaking change as no longer with use core naming enabled the naming patterns match with amqp.
Also this merged very quickly for a non critical fix can we please ask for giving others time to review in future.
Can either this revert this or ensure amqp is alinged when amqp core naming is toggled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on issue #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
brusdev commented on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595731855
@michaelandrepearce I created the PR #3006 to fix the breaking change, ATM I'm using only the clientId if present. Can you review the PR, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on issue
#3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595702996
@brusdev looking at the jira, this implementation requires the client to set client id, which isnt always advisable e.g. the connection is also used for shared durables,. To meet the needs of the jira,
other identifying information then also should be present, e.g. the user + hostname as cannot rely on clientid being set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3002: ARTEMIS-2644
Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3002: ARTEMIS-2644 Include client id into non durable subscriber queue name
URL: https://github.com/apache/activemq-artemis/pull/3002#issuecomment-595555227
@jbertram / @brusdev
Guys this is a breaking change as no longer with use core naming enabled the naming patterns match with amqp.
As well but less critical anyone filtering on metrics based on existing pattern will break.
Also this merged very quickly for a non critical fix can we please ask for giving others time to review in future when features / enhancements
Can either this revert this or ensure amqp is alinged when amqp core naming is toggled, along with making it feature toggle so that its opt in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services