You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 18:05:54 UTC
[GitHub] [arrow] assignUser opened a new pull request, #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
assignUser opened a new pull request, #12844:
URL: https://github.com/apache/arrow/pull/12844
With no explicit exit code `exit /b` returns 0. This made the the step never fail.
The failing test is only for demonstration and will of course be removed prior to merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093149422
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093149398
https://issues.apache.org/jira/browse/ARROW-15951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093297950
Revision: 9aba4f2db85964933f54b671e0c14dd3c7a7cede
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1834](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1834)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1834-github-wheel-windows-cp310-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
URL: https://github.com/apache/arrow/pull/12844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093296965
@github-actions crossbow submit wheel-windows-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093297336
@kszucs could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093169445
Revision: cde2a453d5606f3984cb32978aebeb043f3d0123
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1833](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1833)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1833-github-wheel-windows-cp310-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1093166624
@github-actions crossbow submit wheel-windows-cp310-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #12844:
URL: https://github.com/apache/arrow/pull/12844#discussion_r846386550
##########
ci/scripts/python_wheel_windows_test.bat:
##########
@@ -35,21 +35,21 @@ set ARROW_TEST_DATA=C:\arrow\testing\data
set PARQUET_TEST_DATA=C:\arrow\submodules\parquet-testing\data
@REM Install testing dependencies
-pip install -r C:\arrow\python\requirements-wheel-test.txt || exit /B
+pip install -r C:\arrow\python\requirements-wheel-test.txt || exit /B 1
@REM Install the built wheels
-python -m pip install --no-index --find-links=C:\arrow\python\dist\ pyarrow || exit /B
+python -m pip install --no-index --find-links=C:\arrow\python\dist\ pyarrow || exit /B 1
@REM Test that the modules are importable
-python -c "import pyarrow" || exit /B
-python -c "import pyarrow._hdfs" || exit /B
-python -c "import pyarrow._s3fs" || exit /B
-python -c "import pyarrow.csv" || exit /B
-python -c "import pyarrow.dataset" || exit /B
-python -c "import pyarrow.flight" || exit /B
-python -c "import pyarrow.fs" || exit /B
-python -c "import pyarrow.json" || exit /B
-python -c "import pyarrow.parquet" || exit /B
+python -c "import pyarrow" || exit /B 1
+python -c "import pyarrow._hdfs" || exit /B 1
+python -c "import pyarrow._s3fs" || exit /B 1
+python -c "import pyarrow.csv" || exit /B 1
+python -c "import pyarrow.dataset" || exit /B 1
+python -c "import pyarrow.flight" || exit /B 1
+python -c "import pyarrow.fs" || exit /B 1
+python -c "import pyarrow.json" || exit /B 1
+python -c "import pyarrow.parquet" || exit /B 1
@REM Execute unittest
-pytest -r s --pyargs pyarrow || exit /B
+pytest -r s --pyargs pyarrow || exit /B 1
Review Comment:
This would probably also have worked:
```suggestion
pytest -r s --pyargs pyarrow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12844:
URL: https://github.com/apache/arrow/pull/12844#issuecomment-1094149340
Benchmark runs are scheduled for baseline = 5fa08449a09a452f7a93cd20d0ca1d76a6637449 and contender = 58fe60f59289079f7cb8d88aa195570f22836292. 58fe60f59289079f7cb8d88aa195570f22836292 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/18c291cc94f24712ad3ad57cadd56b77...b2ad2814d91e40bfb4612888475c14af/)
[Finished :arrow_down:1.09% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/71d6c5013dbf445187bc9d32cc0d27be...8407f38ad5f9420ea6f2b513440c8b7e/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/922a5a5d291343d39f81499f9a872a6f...1495dfa98c634be791e09ae85e216602/)
[Finished :arrow_down:0.04% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/539879f6e9f24f379139225ddc6d7745...03aa31b6d49d4a82ade26229c3190073/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/481| `58fe60f5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/466| `58fe60f5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/467| `58fe60f5` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/476| `58fe60f5` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/480| `5fa08449` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/465| `5fa08449` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/466| `5fa08449` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/475| `5fa08449` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org