You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shukitchan <gi...@git.apache.org> on 2015/12/01 09:13:27 UTC
[GitHub] trafficserver pull request: TS-4045: ts_lua improvements
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/357
TS-4045: ts_lua improvements
3 things to accomplish in this jira
1) add support for TSHttpTxnDebugSet
2) protect http context pointer access in api calls
3) fix a spelling mistake from "truncked" to "truncated"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan/trafficserver TS-4045
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit 706829c55d017f7b275fde7c61571eed2bbb31e0
Author: Kit Chan <ki...@apache.org>
Date: 2015-12-01T08:09:46Z
TS-4045: ts_lua improvements
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4045: ts_lua improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4045: ts_lua improvements
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160906831
@bgaff - updated with using macro. thank.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4045: ts_lua improvements
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160890632
@jpeach , would really appreciate if you can take a look and review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4045: ts_lua improvements
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/357#discussion_r46250788
--- Diff: plugins/experimental/ts_lua/ts_lua_client_request.c ---
@@ -332,6 +348,10 @@ ts_lua_client_request_get_pristine_url(lua_State *L)
ts_lua_http_ctx *http_ctx;
http_ctx = ts_lua_get_http_ctx(L);
+ if (http_ctx == NULL) {
--- End diff --
given that this pattern is literally repeated everywhere, perhaps a macro is in order:
```
#define GET_CONTEXT(ctx, list) \
ctx = ts_lua_get_http_ctx(list); \
if (ctx == NULL) { \
TS_ERROR(...); \
return; \
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---