You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/09/25 14:05:59 UTC
[Bug 123350] New: Slide title undo impossible
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Bug ID: 123350
Issue Type: DEFECT
Summary: Slide title undo impossible
Product: Impress
Version: 4.0.1-dev
Hardware: PC
OS: Linux64
Status: CONFIRMED
Severity: normal
Priority: P3
Component: editing
Assignee: issues@openoffice.apache.org
Reporter: elish@mail-page.com
CC: issues@openoffice.apache.org
1. File - New - Presentation
2. Add title
3. Click on "Click to add text"
4. Click on slide background
5. Undo
Title does not disappear.
AOO410m1(Build:9750) - Rev. 1525015
2013-09-24_04:09:45 - Rev. 1525769
4.0.1 RC3 testing
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
--- Comment #11 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1530254 into trunk:
i123350 Added Clear() implementation to SdrUndoManager to only delete text
ed...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orw@apache.org
Latest|--- |4.0.1
Confirmation on| |
Hardware|PC |All
Version|4.1.0-dev |4.0.0
OS|Linux64 |All
--- Comment #7 from Oliver-Rainer Wittmann <or...@apache.org> ---
I reproduced the described defect on Windows 7 64bit in AOO 4.0.0 and AOO
4.0.1, but not in AOO 3.4.0 and AOO 3.4.1.
--> platform = All
--> version = 4.0.0
--> latest confirmation on = 4.0.1
my steps:
- new presentation document with default slide title and slide text placeholder
text frames
- click into slide title and type some text
- click into slide text
- click on slide background
--> only one Undo action - namely "Edit text of Text Frame 'Click to...'"
The important thing to reproduce the defect is that you need to click into
slide text while the cursor is still blinking in slide title. You need to
switch from editing the slide title directly to the editing of the slide text.
in AOO 3.4.0 and AOO 3.4.1 two Undo actions are created - namely:
- "Edit text of Text Frame 'Click to...'"
- "Edit text of Title text 'Click to...'"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
--- Comment #2 from Edwin Sharp <el...@mail-page.com> ---
I think Linux only bug but need to verify.
Was observed on:
CPU[-Quad AMD A6-3420M APU with Radeon HD Graphics clocked at 800.000 Mhz-]
Kernel[-Linux 3.9-0.slh.4-aptosid-amd64 x86_64-] Up[-2:07-]
Mem[-492.3/3436.4MB-] HDD[-504GB(7%used)-] Procs[-146-] Client[Shell]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked possibility (2), but there are caveats:
- The DropDown UndoStack would only show the TextEdit undos
- Only these would be undoable in one run, no selection of longer list
- The State/Execute methods of UNDO/REDO would need to be faked to do the right
thing (e.g. also to show the redos when in TextEdit but no undos, etc.)
There are probably more, thus the current solution (1) with exchanging the undo
stack but limiting it's clearance to text edit bounds, is preferrable. This is
comitted, thus this task is done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
ALG: Has to do with #120498# where I changed the Text undo. The outliner for
text edit gets the undo manager set from the current model to allow smooth
continued action when the user uses CTRL-Z in text edit and the last text edit
command is already undone -> end text edit and continue undoing the last
action.
Problem is that with PresObjs (the predefined text objects in impress) the
Outliner pretty often triggers a Clear() at the undo stack. If this undo stack
is the already set global one, too much is cleared.
There are two possible solutions:
(1) overload Clear() in SdrUndoManager and clear only up to the TextEdit's
start point where itis undo stack was set (works, just added that code)
(2) remove #120498# and solve much simpler
Implemented (1) and it works, will commit that. I will also take the time and
check if (2) is doable, this would make things much easier. Less complicated is
always better.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Edwin Sharp <el...@mail-page.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #6 from Edwin Sharp <el...@mail-page.com> ---
Confirmed on another PC.
Rev. 1524958 Debian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Edwin Sharp <el...@mail-page.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |UNCONFIRMED
Version|4.0.1-dev |4.1.0-dev
Ever confirmed|1 |0
--- Comment #4 from Edwin Sharp <el...@mail-page.com> ---
Updating fields.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
--- Comment #3 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
NOT reproducible with "AOO 4.1.0-Dev – English UI / German locale -
[AOO410m1(Build:9750) - Rev. 1525917 - 2013-09-25]" on German WIN7 Home
Premium (64bit)", own separate user profile.
That underpins "Linux only" suspect
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
Latest|4.0.1 |---
Confirmation on| |
Hardware|All |PC
Version|4.0.0 |4.1.0-dev
OS|All |Linux64
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Has nothing to do with thext edit or changing directly from one text edit
to another one. Whatever is onthe undo stack, when activating the PresObj and
ending this text edit (adding text or not) the undo stack is gone - only one
text edit action remains (which seems to do nothing because pre and post use
the 'Click here to ...' text). Checking deeper...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
zhaoshzh <ao...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aoo.zhaoshzh@gmail.com
--- Comment #13 from zhaoshzh <ao...@gmail.com> ---
verified on AOO410m15(Build:9761) - Rev. 1585021
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
--- Comment #5 from Edwin Sharp <el...@mail-page.com> ---
Description valid also for:
AOO401m5(Build:9714) - Rev. 1524958
2013-09-20 11:54 - Linux x86_64
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rainerbielefeld_ooo_qa@biel
| |efeldundbuss.de
--- Comment #1 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
I tried with an additional step "3.1 - Type few words"
NOT reproducible with "AOO 4.1.0-Dev – English UI / German locale -
[AOO410m1(Build:9750) - Rev. 1523968 - 2013-09-18]" on German WIN7 Home
Premium (64bit)", own separate user profile.
Very new Regression? Linux related?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
zhaoshzh <ao...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #14 from zhaoshzh <ao...@gmail.com> ---
verified on AOO410m14(Build:9760) - Rev. 1585624
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|--- |4.0.1
Confirmation on| |
Hardware|PC |All
Version|4.1.0-dev |4.0.0
OS|Linux64 |All
--- Comment #9 from Oliver-Rainer Wittmann <or...@apache.org> ---
revert Armin's changes to fields 'Version', 'Hardware' and 'Latest Confirmation
on'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123350] Slide title undo impossible
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123350
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.1.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.