You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2022/02/25 07:58:20 UTC

[pulsar] 01/13: [CI]Upgrade Windows runner os to windows-2022 and generator to Visual Studio 17 2022 (#14368)

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit b20b6f24aaf825f7a9c144c4d4143ffa3350fcf9
Author: Lishen Yao <ya...@gmail.com>
AuthorDate: Fri Feb 18 18:37:27 2022 +0800

    [CI]Upgrade Windows runner os to windows-2022 and generator to Visual Studio 17 2022 (#14368)
    
    ### Motivation
    
    As github windows runner latest upgrade to [2022](https://github.com/actions/virtual-environments/issues/4856), the `ci-cpp-build-windows.yaml` workflow should be changed otherwise the action would be failed such as [this one](https://github.com/apache/pulsar/actions/runs/1860147632)
    
    ### Modifications
    
    - Upgrade os version to 2022
    - Change generator to `Visual Studio 17 2022`
    
    (cherry picked from commit 0facd24e8eec2df56f6f241ce2cf87eb98590a7e)
---
 .github/workflows/ci-cpp-build-windows.yaml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci-cpp-build-windows.yaml b/.github/workflows/ci-cpp-build-windows.yaml
index a287a4c..c622b65 100644
--- a/.github/workflows/ci-cpp-build-windows.yaml
+++ b/.github/workflows/ci-cpp-build-windows.yaml
@@ -46,18 +46,18 @@ jobs:
       matrix:
         include:
           - name: 'Windows x64'
-            os: windows-latest
+            os: windows-2022
             triplet: x64-windows
             vcpkg_dir: 'C:\vcpkg'
             suffix: 'windows-win64'
-            generator: 'Visual Studio 16 2019'
+            generator: 'Visual Studio 17 2022'
             arch: '-A x64'
           - name: 'Windows x86'
-            os: windows-latest
+            os: windows-2022
             triplet: x86-windows
             vcpkg_dir: 'C:\vcpkg'
             suffix: 'windows-win32'
-            generator: 'Visual Studio 16 2019'
+            generator: 'Visual Studio 17 2022'
             arch: '-A Win32'
 
     steps:
@@ -65,7 +65,7 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Detect changed files
-        id:   changes
+        id: changes
         uses: apache/pulsar-test-infra/paths-filter@master
         with:
           filters: .github/changes-filter.yaml