[jira] [Commented] (ARROW-3467) Building against external double conversion is broken

["Antoine Pitrou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642298#comment-16642298 ] 

Antoine Pitrou commented on ARROW-3467:
---------------------------------------

I don't understand what you mean. We already build against v3.1.1. Can you elaborate?

> Building against external double conversion is broken
> -----------------------------------------------------
>
>                 Key: ARROW-3467
>                 URL: https://issues.apache.org/jira/browse/ARROW-3467
>             Project: Apache Arrow
>          Issue Type: Bug
>    Affects Versions: 0.11.0
>            Reporter: Dmitry Kalinkin
>            Assignee: Dmitry Kalinkin
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> double-conversion 3.1.1 defines double-conversion::double-conversion target instead of double-conversion [1]. So the build fails with:
> {noformat}
> CMake Error at cmake_modules/BuildUtils.cmake:98 (message):
>   No static or shared library provided for double-conversion
> Call Stack (most recent call first):
>   cmake_modules/ThirdpartyToolchain.cmake:476 (ADD_THIRDPARTY_LIB)
>   CMakeLists.txt:386 (include)
> {noformat}
> [1] https://github.com/google/double-conversion/commit/e13e72e17692f5dc0036460d734c637b563f3ac7#diff-af3b638bc2a3e6c650974192a53c7291R57



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)