You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2024/10/16 04:52:37 UTC

[PR] Revert #190 and #189 [skywalking-showcase]

kezhenxu94 opened a new pull request, #192:
URL: https://github.com/apache/skywalking-showcase/pull/192

   Turns out the annotation is not added and the r3-load pod can’t be terminated, I’m going to revert this for now. @mrproliu if you want please find the correct way to avoid injecting the sidecar.
   
   <img width="1627" alt="image" src="https://github.com/user-attachments/assets/198922c0-edb7-47f0-a21d-c8b32834f037">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert #190 and #189 [skywalking-showcase]

Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #192:
URL: https://github.com/apache/skywalking-showcase/pull/192#issuecomment-2415729038

   Got it, Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert #190 and #189 [skywalking-showcase]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #192:
URL: https://github.com/apache/skywalking-showcase/pull/192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org