You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/09/20 14:24:42 UTC
Review Request 62438: Ignored redundant agent resources updates in
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62438/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Repository: mesos
Description
-------
In the future, agents will send updates on their total, e.g., when
resource providers are added or removed. As an update to the agent's
total resources currently triggers rescinding of all offered agent
resources, spurious updates can negatively affect in-flight offer
operations.
This patch changes the master so that updates introducing no changes
(i.e., the new resources are identical to the old resources) are
dropped and do not trigger rescinding of offers anymore. We also
adjust the handling of oversubscribed agent resources to drop
redundant updates.
Diffs
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62438/diff/1/
Testing
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier
Re: Review Request 62438: Ignored redundant agent resources updates in
master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62438/#review185926
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 6753 (patched)
<https://reviews.apache.org/r/62438/#comment262257>
You missed a `return` here?
- Jie Yu
On Sept. 20, 2017, 2:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62438/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 2:24 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the future, agents will send updates on their total, e.g., when
> resource providers are added or removed. As an update to the agent's
> total resources currently triggers rescinding of all offered agent
> resources, spurious updates can negatively affect in-flight offer
> operations.
>
> This patch changes the master so that updates introducing no changes
> (i.e., the new resources are identical to the old resources) are
> dropped and do not trigger rescinding of offers anymore. We also
> adjust the handling of oversubscribed agent resources to drop
> redundant updates.
>
>
> Diffs
> -----
>
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
>
>
> Diff: https://reviews.apache.org/r/62438/diff/1/
>
>
> Testing
> -------
>
> Tested on a number of platforms on internal CI.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62438: Ignored redundant agent resources updates in
master.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62438/#review186109
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Sept. 22, 2017, 5:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62438/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 5:03 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the future, agents will send updates on their total, e.g., when
> resource providers are added or removed. As an update to the agent's
> total resources currently triggers rescinding of all offered agent
> resources, spurious updates can negatively affect in-flight offer
> operations.
>
> This patch changes the master so that updates introducing no changes
> (i.e., the new resources are identical to the old resources) are
> dropped and do not trigger rescinding of offers anymore. We also
> adjust the handling of oversubscribed agent resources to drop
> redundant updates.
>
>
> Diffs
> -----
>
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
>
>
> Diff: https://reviews.apache.org/r/62438/diff/2/
>
>
> Testing
> -------
>
> Tested on a number of platforms on internal CI.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62438: Ignored redundant agent resources updates in
master.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62438/
-----------------------------------------------------------
(Updated Sept. 22, 2017, 5:03 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Added a missing return.
Repository: mesos
Description
-------
In the future, agents will send updates on their total, e.g., when
resource providers are added or removed. As an update to the agent's
total resources currently triggers rescinding of all offered agent
resources, spurious updates can negatively affect in-flight offer
operations.
This patch changes the master so that updates introducing no changes
(i.e., the new resources are identical to the old resources) are
dropped and do not trigger rescinding of offers anymore. We also
adjust the handling of oversubscribed agent resources to drop
redundant updates.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62438/diff/2/
Changes: https://reviews.apache.org/r/62438/diff/1-2/
Testing
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier