You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/20 19:56:31 UTC
[GitHub] [kafka] kowshik opened a new pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
kowshik opened a new pull request #9465:
URL: https://github.com/apache/kafka/pull/9465
The method `TopicCommand. askToProceed()` is unused. So I've removed it in this PR.
I'm relying on existing tests to report any regressions, but I code searched for the method in GitHub and it was not used at other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713261852
@chia7712 Thanks, would you be able to merge it? I don't have permission to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713262554
> Thanks, would you be able to merge it? I don't have permission to do it.
done :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9465:
URL: https://github.com/apache/kafka/pull/9465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713255922
@gwenshap @chia7712: Thanks for the review. The tests have mostly passed. There is one failure in JDK 15: `kafka.api.TransactionsBounceTest.testWithGroupId` but thats related to this PR. Would it be ok to merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713285315
Thanks @chia7712 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik edited a comment on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
kowshik edited a comment on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713255922
@gwenshap @chia7712: Thanks for the review. The tests have mostly passed. There is one failure in JDK 15: `kafka.api.TransactionsBounceTest.testWithGroupId` but thats not related to this PR. Would it be ok to merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gwenshap commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
gwenshap commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713132248
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9465: MINOR: Remove unused TopicCommand.askToProceed() method
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9465:
URL: https://github.com/apache/kafka/pull/9465#issuecomment-713260549
> Would it be ok to merge this PR?
sure. thanks for your patch. Merge it to trunk :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org