Re: [PR] AIP-72: Allow pushing and pulling XCom from Task Context [airflow]

["kaxil (via GitHub)" <gi...@apache.org>]

kaxil commented on code in PR #45075:
URL: https://github.com/apache/airflow/pull/45075#discussion_r1896561629


##########
tests/api_fastapi/execution_api/routes/test_xcoms.py:
##########
@@ -40,19 +41,21 @@ class TestXComsGetEndpoint:
     @pytest.mark.parametrize(
         ("value", "expected_value"),
         [
-            ("value1", "value1"),
-            ({"key2": "value2"}, {"key2": "value2"}),
-            ({"key2": "value2", "key3": ["value3"]}, {"key2": "value2", "key3": ["value3"]}),
-            (["value1"], ["value1"]),
+            ('"value1"', '"value1"'),
+            ('{"key2": "value2"}', '{"key2": "value2"}'),
+            ('{"key2": "value2", "key3": ["value3"]}', '{"key2": "value2", "key3": ["value3"]}'),
+            ('["value1"]', '["value1"]'),

Review Comment:
   Now the contract between API Server and its client is simple: It expects JSON serialized string and will return string. 
   
   It pushes down responsibility to serialize it into native (Python, Golang) format to the respective clients.
   
   In one of the future PRs, I will move some of the serialization and deserialization logic in Python clients



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org