You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/01/19 21:39:14 UTC

[GitHub] flink pull request #5321: [FLINK-8465] [flip6] Retrieve correct leader compo...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5321

    [FLINK-8465] [flip6] Retrieve correct leader component address in ClusterClient

    ## What is the purpose of the change
    
    Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The
    returned LeaderConnectionInfo contains the address of the leading cluster
    component. In the old code this is the JobManager whereas in Flip-6 it is the
    Dispatcher.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink clusterClientLeaderAddress

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5321
    
----
commit d7407d13a4e023d714312c9ebd854b6cc322a8da
Author: Till Rohrmann <tr...@...>
Date:   2018-01-19T21:18:35Z

    [FLINK-8465] [flip6] Retrieve correct leader component address in ClusterClient
    
    Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The
    returned LeaderConnectionInfo contains the address of the leading cluster
    component. In the old code this is the JobManager whereas in Flip-6 it is the
    Dispatcher.

----


---

[GitHub] flink pull request #5321: [FLINK-8465] [flip6] Retrieve correct leader compo...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/5321


---

[GitHub] flink issue #5321: [FLINK-8465] [flip6] Retrieve correct leader component ad...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5321
  
    Thanks for the review @GJL. Rebasing and merging once Travis gives green light.


---