You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "chenyu-opensource (via GitHub)" <gi...@apache.org> on 2023/12/04 09:36:16 UTC
[PR] [SPARK-46239][CORE] Hide the version information of Spark Jetty [spark]
chenyu-opensource opened a new pull request, #44158:
URL: https://github.com/apache/spark/pull/44158
**What changes were proposed in this pull request?**
The PR sets parameters to hide the version of jetty in spark.
**Why are the changes needed?**
It can avoid obtaining remote WWW service information through HTTP.
**Does this PR introduce any user-facing change?**
No
**How was this patch tested?**
Manual review
**Was this patch authored or co-authored using generative AI tooling?**
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide `Jetty` info [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44158:
URL: https://github.com/apache/spark/pull/44158#issuecomment-1839653872
Oops. Sorry, @chenyu-opensource . The commit log seems be screwed due to https://github.com/apache/spark/pull/44158/commits/33df20947ec3b7e06aa423c658cae299220d364d, https://github.com/apache/spark/pull/44158/commits/74a61ebd8fd34ae0796cd417a1cc626bdf4b3d6a, https://github.com/apache/spark/pull/44158/commits/7693bfdf058312e90337e8dfa351c037cd1255a7 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide `Jetty` info [spark]
Posted by "chenyu-opensource (via GitHub)" <gi...@apache.org>.
chenyu-opensource commented on PR #44158:
URL: https://github.com/apache/spark/pull/44158#issuecomment-1839853761
> The JIRA issue, [SPARK-46239](https://issues.apache.org/jira/browse/SPARK-46239), is correctly assigned to you.
Thank you so much for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide `Jetty` info [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44158:
URL: https://github.com/apache/spark/pull/44158#issuecomment-1839648573
I merged this master/3.5/3.4/3.3 as a release manager of Apache Spark 3.3.4 EOL release.
Thank you again, @chenyu-opensource .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide the version information of Spark Jetty [spark]
Posted by "chenyu-opensource (via GitHub)" <gi...@apache.org>.
chenyu-opensource commented on PR #44158:
URL: https://github.com/apache/spark/pull/44158#issuecomment-1838177078
After that, we can hide the information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide the version information of Spark Jetty [spark]
Posted by "chenyu-opensource (via GitHub)" <gi...@apache.org>.
chenyu-opensource commented on PR #44158:
URL: https://github.com/apache/spark/pull/44158#issuecomment-1838174465
For example, we need to hide the version of jetty to prevent information leakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46239][CORE] Hide `Jetty` info [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44158: [SPARK-46239][CORE] Hide `Jetty` info
URL: https://github.com/apache/spark/pull/44158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org