You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by simonellistonball <gi...@git.apache.org> on 2018/07/19 13:57:11 UTC

[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements

GitHub user simonellistonball opened a pull request:

    https://github.com/apache/metron/pull/1113

    METRON-1667 Remove the JPA and MySQL elements

    ## Contributor Comments
    
    Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. 
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/simonellistonball/metron METRON-1667

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1113
    
----
commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50
Author: Simon Elliston Ball <si...@...>
Date:   2018-07-04T11:22:42Z

    Removed plugins for eclipselink since jpa is no longer included

commit 181d38243bfdc4d75b28891a3b06510391c8d4f2
Author: Simon Elliston Ball <si...@...>
Date:   2018-07-12T17:15:16Z

    Removed configs for JPA

commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3
Author: Simon Elliston Ball <si...@...>
Date:   2018-07-12T17:20:50Z

    Remove JPA elements

commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804
Author: Simon Elliston Ball <si...@...>
Date:   2018-07-19T13:46:52Z

    updated dependencies list to reflect removal of JPA

----


---

[GitHub] metron issue #1113: METRON-1667 Remove the JPA and MySQL elements

Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the issue:

    https://github.com/apache/metron/pull/1113
  
    Apologies, re-submitting against the feature branch.


---

[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements

Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball closed the pull request at:

    https://github.com/apache/metron/pull/1113


---