You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/02/08 02:00:51 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7339: Updated docs for DS server capability.
ocket8888 commented on code in PR #7339:
URL: https://github.com/apache/trafficcontrol/pull/7339#discussion_r1099554904
##########
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html:
##########
@@ -343,11 +343,14 @@ <h3 ng-if="!open()">Previous Value</h3>
</div>
</div>
<div class="form-group" ng-class="{'has-error': hasError(generalConfig.requiredCapabilities), 'has-feedback': hasError(generalConfig.requiredCapabilities)}">
- <label class="has-tooltip control-label col-md-2 col-sm-2 col-xs-12" for="capability">Required Capability
+ <div class="has-tooltip control-label col-md-2 col-sm-2 col-xs-12" for="capability">
+ <label>Required Capability</label>
Review Comment:
Same as above
##########
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html:
##########
@@ -343,11 +343,14 @@ <h3 ng-if="!open()">Previous Value</h3>
</div>
</div>
<div class="form-group" ng-class="{'has-error': hasError(generalConfig.requiredCapabilities), 'has-feedback': hasError(generalConfig.requiredCapabilities)}">
- <label class="has-tooltip control-label col-md-2 col-sm-2 col-xs-12" for="capability">Required Capability
+ <div class="has-tooltip control-label col-md-2 col-sm-2 col-xs-12" for="capability">
Review Comment:
This `for` attribute needs to be on the `<label>` tag below it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org