You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/23 17:12:22 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10142: build: enable test coverage only for CI
ktmud opened a new pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142
# SUMMARY
Currently Python unit tests via `nosetests` always output test coverage, but there's no way to disable it. The very long coverage report is quite annoying and makes it more difficult to scan test errors, especially when you just want to run a single test.
<img src="https://user-images.githubusercontent.com/335541/85433684-a2f5c300-b539-11ea-880d-46210ee4dbb2.png" width="400" />
This PR disables test coverage by default, but reenables it for CI jobs that run the full test suite.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See SUMMARY
### TEST PLAN
Make sure test coverage still reported for GitHub PRs.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142#issuecomment-648457616
Hmm, Codecov still not reporting coverage, even though it looks normal from build logs. Close and re-open to see if it fixes the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142#issuecomment-650428280
Codecov still acting weird. Close in favor of #10177 .
@bkyryliuk could you make sure `pytest` doesn't output the same type of junk coverage report when running a single test locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142#issuecomment-650428280
Close in favor of #10177 . @bkyryliuk could you make sure pytest doesn't output the same type of junk coverage report when running a single test locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #10142: build: enable test coverage only for CI
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10142:
URL: https://github.com/apache/incubator-superset/pull/10142#issuecomment-649084980
I'm a big fan of this change. Once codecov is working on this branch count me in for an approval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org