You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by lulf <gi...@git.apache.org> on 2016/10/26 08:23:57 UTC
[GitHub] activemq-artemis pull request #867: ARTEMIS-824: Add management routines for...
GitHub user lulf opened a pull request:
https://github.com/apache/activemq-artemis/pull/867
ARTEMIS-824: Add management routines for connector services
This adds management operations for creating and destroying connector services at run time. This feature is needed when building a messaging service where the topology changes and the broker must be disconnected from the network.
I made the ConnectorsService class thread safe in case the management operations can be called concurrently. I'd also like to hear your thoughts on the exception handling. I've tried to do the same 'ignore and log' behavior when creating the connector services at startup. For management requests, I think the errors should be propagated to the client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EnMasseProject/activemq-artemis ARTEMIS-824
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/867.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #867
----
commit 1b7033a20e3e529595ce1ae28b4b389bfd220e43
Author: Ulf Lilleengen <lu...@redhat.com>
Date: 2016-10-25T13:40:37Z
ARTEMIS-824: Add management routines for connector services
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #867: ARTEMIS-824: Add management routines for connec...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/867
@lulf I have run big part of the testsuite and so far no issues. I will merge it already.
(If I see anything wrong I may ping you... but most likely it's ok)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #867: ARTEMIS-824: Add management routines for connec...
Posted by lulf <gi...@git.apache.org>.
Github user lulf commented on the issue:
https://github.com/apache/activemq-artemis/pull/867
@clebertsuconic I'm not able to reproduce the issue. Both with and without skipTests=true works for me. From the jenkins test run it looks like it timed out, and I'm not able to find any test results. Is it possible to rerun the build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #867: ARTEMIS-824: Add management routines for connec...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/867
@lulf build failure on this PR is accurate (apparently). Can you fix it?
Try
```
mvn -Pdev install -DskipTests=true
```
on your local box.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #867: ARTEMIS-824: Add management routines for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/867
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---