You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by ro...@apache.org on 2014/02/11 21:29:39 UTC
git commit: THRIFT-2351 PHP TCompactProtocol has fails to decode
messages Patch: Paul Banks
Updated Branches:
refs/heads/master 3bf62d1d8 -> 47b89b958
THRIFT-2351 PHP TCompactProtocol has fails to decode messages
Patch: Paul Banks
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/47b89b95
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/47b89b95
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/47b89b95
Branch: refs/heads/master
Commit: 47b89b9584d224a7e0053768b6c7c954eb42bf33
Parents: 3bf62d1
Author: Roger Meier <ro...@apache.org>
Authored: Tue Feb 11 21:28:56 2014 +0100
Committer: Roger Meier <ro...@apache.org>
Committed: Tue Feb 11 21:28:56 2014 +0100
----------------------------------------------------------------------
lib/php/lib/Thrift/Protocol/TCompactProtocol.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/47b89b95/lib/php/lib/Thrift/Protocol/TCompactProtocol.php
----------------------------------------------------------------------
diff --git a/lib/php/lib/Thrift/Protocol/TCompactProtocol.php b/lib/php/lib/Thrift/Protocol/TCompactProtocol.php
index e637a59..880da25 100644
--- a/lib/php/lib/Thrift/Protocol/TCompactProtocol.php
+++ b/lib/php/lib/Thrift/Protocol/TCompactProtocol.php
@@ -387,8 +387,8 @@ class TCompactProtocol extends TProtocol {
if ($version != TCompactProtocol::VERSION) {
throw new TProtocolException('Bad version in TCompact message');
}
- $result += $this->readVarint($seqId);
- $name += $this->readString($name);
+ $result += $this->readVarint($seqid);
+ $result += $this->readString($name);
return $result;
}