[GitHub] csantanapr commented on a change in pull request #2112: Allow docker actions with zip files.

[gi...@git.apache.org]

csantanapr commented on a change in pull request #2112: Allow docker actions with zip files. 
URL: https://github.com/apache/incubator-openwhisk/pull/2112#discussion_r122346435
 
 

 ##########
 File path: docs/actions.md
 ##########
 @@ -827,12 +827,19 @@ For the instructions that follow, assume that the Docker user ID is `janesmith`
 
 
   ```
-  wsk action create --docker example janesmith/blackboxdemo
+  wsk action create example --docker janesmith/blackboxdemo
   ```
 
   Notice the use of `--docker` when creating an action. Currently all Docker images are assumed to be hosted on Docker Hub.
   The action may be invoked as any other OpenWhisk action.
 
+  *Note:* Previous version of the CLI supported `--docker` without a parameter and the image name was a positional argument.
+  In order to allow Docker actions to accept initialization data via a (zip) file, similar to other actions kinds, we have
+  normalized the user experience for Docker actions so that a positional argument if present must be a file (e.g., a zip file)
 
 Review comment:
   let's add short example on how to use action_zip with `--native`
   ```
   #!/bin/bash
   
   echo "{\"message\": \"Hello World\"}"
   ```
   name the script `exec`
   create action.zip
   ```
   zip action.zip exec
   ```
   
   You can run this script with the image you created previously, or extending one of the runtimes languages, or the default base one in alpine linux 
   ``` 
   wsk action create example action.zip --docker openwhisk/dockerskeleton
   ```
   Or use the short version using `--native`
   ```
   wsk action create example action.zip --native
   ```
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services