You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "appletreeisyellow (via GitHub)" <gi...@apache.org> on 2024/01/30 00:30:49 UTC

[PR] chore(date_trunc): turn panic into unimplemented error for ambiguous time [arrow-datafusion]

appletreeisyellow opened a new pull request, #9061:
URL: https://github.com/apache/arrow-datafusion/pull/9061

   ## Which issue does this PR close?
   
   Part of #8899
   
   ## Rationale for this change
   
   `date_trunc` panics when time is ambiguous between "daylight saving time" and standard time
   
   ## What changes are included in this PR?
   
   Instead panic, return an "not yet implemented" error with workaround suggestion. 
   
   ## Are these changes tested?
   
    Yes, included more tests
   
   ## Are there any user-facing changes?
   
   Yes, user will no longer get panic, but a clearer error with workaround suggestion
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(date_trunc): turn panic into unimplemented error for ambiguous time [arrow-datafusion]

Posted by "appletreeisyellow (via GitHub)" <gi...@apache.org>.
appletreeisyellow closed pull request #9061: chore(date_trunc): turn panic into unimplemented error for ambiguous time
URL: https://github.com/apache/arrow-datafusion/pull/9061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore(date_trunc): turn panic into unimplemented error for ambiguous time [arrow-datafusion]

Posted by "appletreeisyellow (via GitHub)" <gi...@apache.org>.
appletreeisyellow commented on PR #9061:
URL: https://github.com/apache/arrow-datafusion/pull/9061#issuecomment-1916891936

   Fixed in https://github.com/apache/arrow-datafusion/pull/9068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org