You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oltu.apache.org by "Antonio Sanso (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 17:01:40 UTC
[jira] [Created] (AMBER-45) Authorization Response needs to be
updated to latest spec
Authorization Response needs to be updated to latest spec
---------------------------------------------------------
Key: AMBER-45
URL: https://issues.apache.org/jira/browse/AMBER-45
Project: Amber
Issue Type: Bug
Components: OAuth 2.0 - Authorization Server
Reporter: Antonio Sanso
As for [0]
state
REQUIRED if the "state" parameter was present in the client
authorization request. The exact value received from the
client.
patch to follow
[0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated AMBER-45:
-------------------------------
Attachment: AMBER-45-patch.txt
attaching proposed patch
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193953#comment-13193953 ]
Antonio Sanso commented on AMBER-45:
------------------------------------
I'd consider the comment from Tommaso positive (with the new patch released).
I'll still wait further 72hours and if no veto I'll commit the patch,
Thanks
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated AMBER-45:
-------------------------------
Attachment: AMBER-45-patch.txt
thanks for spotting it Tommaso. Attaching new patch
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso resolved AMBER-45.
--------------------------------
Resolution: Fixed
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Tommaso Teofili (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194255#comment-13194255 ]
Tommaso Teofili commented on AMBER-45:
--------------------------------------
yes, go for it!
Tommaso
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated AMBER-45:
-------------------------------
Comment: was deleted
(was: thanks for spotting it Tommaso. Attaching new patch)
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Tommaso Teofili (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177191#comment-13177191 ]
Tommaso Teofili commented on AMBER-45:
--------------------------------------
making it package local seems ok to me.
Also note that the above patch makes the integration-tests fail due to :
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project oauth2-integration-tests: Compilation failure
[ERROR] .../amber/trunk/oauth-2.0/oauth2-integration-tests/src/test/java/org/apache/amber/oauth2/integration/endpoints/AuthzEndpoint.java:[68,16] authorizationResponse(javax.servlet.http.HttpServletRequest,int) in org.apache.amber.oauth2.as.response.OAuthASResponse cannot be applied to (int)
Nothing serious, just I think the test should be updated.
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso reassigned AMBER-45:
----------------------------------
Assignee: Antonio Sanso
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196133#comment-13196133 ]
Antonio Sanso commented on AMBER-45:
------------------------------------
Committed patch in revision 1237665.
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso closed AMBER-45.
------------------------------
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Fix For: 0.22
>
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili updated AMBER-45:
---------------------------------
Fix Version/s: 0.22
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Fix For: 0.22
>
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated AMBER-45:
-------------------------------
Attachment: AMBER-45-patch.txt
thanks for spotting it Tommaso. Attaching new patch
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso updated AMBER-45:
-------------------------------
Attachment: (was: AMBER-45-patch.txt)
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt, AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMBER-45) Authorization Response needs to be
updated to latest spec
Posted by "Antonio Sanso (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167515#comment-13167515 ]
Antonio Sanso commented on AMBER-45:
------------------------------------
As further comment associated this issue I was wondering if
OAuthAuthorizationResponseBuilder#setState
should be kept public at all.....
> Authorization Response needs to be updated to latest spec
> ---------------------------------------------------------
>
> Key: AMBER-45
> URL: https://issues.apache.org/jira/browse/AMBER-45
> Project: Amber
> Issue Type: Bug
> Components: OAuth 2.0 - Authorization Server
> Reporter: Antonio Sanso
> Attachments: AMBER-45-patch.txt
>
>
> As for [0]
> state
> REQUIRED if the "state" parameter was present in the client
> authorization request. The exact value received from the
> client.
> patch to follow
> [0] http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-4.1.2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira