You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "junkaixue (via GitHub)" <gi...@apache.org> on 2023/05/05 00:20:02 UTC

[GitHub] [helix] junkaixue commented on pull request #2478: Add hashCode() to AssignableReplica and fix logic in hash-based collection

junkaixue commented on PR #2478:
URL: https://github.com/apache/helix/pull/2478#issuecomment-1535552529

   Could you please elaborate why the Set does not work? We are using set because of we do observe the list operation can cause a huge delay in computation for other scenarios.
   
   Unless we have a strong reason using List or clear drawback for Set, I prefer to keep the set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org