You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/26 09:00:57 UTC
[GitHub] [mynewt-newt] Reynevan94 opened a new pull request #389:
INSTALLING.md fix
Reynevan94 opened a new pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389
- corrected requiered version of Go
- second method of installation made easier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-newt] utzig commented on a change in pull request #389:
INSTALLING.md fix
Posted by GitBox <gi...@apache.org>.
utzig commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398477438
##########
File path: INSTALLING.md
##########
@@ -25,12 +25,13 @@ following path, relative to the source directory:
If you do not wish to run the included script, you can build newt manually with Go as follows (executed from the source directory):
```no-highlight
- $ mkdir "$GOPATH"/src/mynewt.apache.org
- $ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
- $ go install mynewt.apache.org/newt/newt
+ $ cd "$GOPATH"/src/
+ $ git clone https://github.com/apache/mynewt-newt
+ $ cd mynewt-newt/newt
+ $ go get
```
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
Review comment:
> I think so, because `go help get` returns, among other things:
>
> ```
> Get downloads the packages named by the import paths, along with their
> dependencies. It then installs the named packages, like 'go install'.
> ```
`go get` only downloads the dependencies, to build you still need to run `go build`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-newt] Reynevan94 commented on a change in pull request
#389: INSTALLING.md fix
Posted by GitBox <gi...@apache.org>.
Reynevan94 commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398459968
##########
File path: INSTALLING.md
##########
@@ -25,12 +25,13 @@ following path, relative to the source directory:
If you do not wish to run the included script, you can build newt manually with Go as follows (executed from the source directory):
```no-highlight
- $ mkdir "$GOPATH"/src/mynewt.apache.org
- $ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
- $ go install mynewt.apache.org/newt/newt
+ $ cd "$GOPATH"/src/
+ $ git clone https://github.com/apache/mynewt-newt
+ $ cd mynewt-newt/newt
+ $ go get
```
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
Review comment:
I think so, because `go help get` returns, among other things:
```
Get downloads the packages named by the import paths, along with their
dependencies. It then installs the named packages, like 'go install'.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-newt] sjanc commented on a change in pull request #389:
INSTALLING.md fix
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #389: INSTALLING.md fix
URL: https://github.com/apache/mynewt-newt/pull/389#discussion_r398446722
##########
File path: INSTALLING.md
##########
@@ -25,12 +25,13 @@ following path, relative to the source directory:
If you do not wish to run the included script, you can build newt manually with Go as follows (executed from the source directory):
```no-highlight
- $ mkdir "$GOPATH"/src/mynewt.apache.org
- $ cp -r * "$GOPATH"/src/mynewt.apache.org # Or untar to this path
- $ go install mynewt.apache.org/newt/newt
+ $ cd "$GOPATH"/src/
+ $ git clone https://github.com/apache/mynewt-newt
+ $ cd mynewt-newt/newt
+ $ go get
```
-This puts the newt binary in $GOPATH/bin
+This builds the newt from repository and installs it in the system.
Review comment:
Does "go get" really do that? For me it only downloads dependencies (as stated in go help).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services