You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/07 14:50:13 UTC
[GitHub] [ozone] ArafatKhan2198 opened a new pull request, #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
ArafatKhan2198 opened a new pull request, #3488:
URL: https://github.com/apache/ozone/pull/3488
## What changes were proposed in this pull request?
We will first add new metrics to the SCM and OM via the JMX-bean and then expose those metrics to the UI-Page of SCM and OM.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6840
## How was this patch tested?
The changes were reflected upon the SCM and the OM UI
<img width="1728" alt="Screenshot 2022-06-07 at 8 17 17 PM" src="https://user-images.githubusercontent.com/98023601/172410507-bd0ba6eb-39fd-4035-8bdf-abc39265c0f8.png">
<img width="1728" alt="Screenshot 2022-06-07 at 8 18 38 PM" src="https://user-images.githubusercontent.com/98023601/172410934-a3750af5-127c-43bf-9b65-5918d1e2e6c9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891955411
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
Thanks for the find !! "
I forgot to use it in the SCM UI, I have added it now !!
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
Thanks for the find !!
I forgot to use it in the SCM UI, I have added it now !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891731188
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java:
##########
@@ -28,4 +28,9 @@
public interface OMMXBean extends ServiceRuntimeInfo {
String getRpcPort();
+
+ String getOmRatisLogDirectory();
+
+ String getOmRocksDbDirectory();
Review Comment:
```suggestion
String getRatisLogDirectory();
String getRocksDbDirectory();
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java:
##########
@@ -80,4 +80,7 @@ public interface SCMMXBean extends ServiceRuntimeInfo {
*/
String getPrimordialNode();
+ String getScmRatisLogDirectory();
+
+ String getScmRocksDbDirectory();
Review Comment:
suggest to drop the word "Scm" because everything in this MXBean is for SCM. It's redundant.
```suggestion
String getRatisLogDirectory();
String getRocksDbDirectory();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Add MetaData volume information to the SCM and OM - UI
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r893162234
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
https://issues.apache.org/jira/browse/HDDS-6863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang merged pull request #3488: HDDS-6840. Add MetaData volume information to the SCM and OM - UI
Posted by GitBox <gi...@apache.org>.
jojochuang merged PR #3488:
URL: https://github.com/apache/ozone/pull/3488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on PR #3488:
URL: https://github.com/apache/ozone/pull/3488#issuecomment-1149477205
@sadanand48 @siddhantsangwan @adoroszlai can you please review this patch !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891940950
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
Do we need this in here? As far as I understand we are only using `ctrl.overview` only in the html file
##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -113,5 +113,12 @@
require: {
overview: "^overview"
},
+ controller: function ($http) {
+ var ctrl = this;
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
Review Comment:
Do we need to specify the localhost here ? I mean the fully qualified path?
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -74,6 +74,20 @@ <h2>Status</h2>
</tbody>
</table>
+<h2>Meta-Data Volume Information</h2>
+<table class="table table-bordered table-striped" class="col-md-6">
+ <tbody>
+ <tr>
+ <td>Ratis Directory</td>
+ <td>{{$ctrl.overview.jmx.ScmRatisLogDirectory}}</td>
Review Comment:
Now that the method name is getRatisLogDirectory , I think you need to change it here as well , same for rocksdb dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Add MetaData volume information to the SCM and OM - UI
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891955411
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
Thanks for the find !!
I have removed it and will soon be adding this information in a separate JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891955411
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -26,6 +26,12 @@
},
controller: function ($http) {
var ctrl = this;
+
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result){
+ ctrl.role = result.data.beans[0]
Review Comment:
Yes I forgot to remove it !!
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r892435065
##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -113,5 +113,12 @@
require: {
overview: "^overview"
},
+ controller: function ($http) {
+ var ctrl = this;
+ $http.get("http://localhost:9874/jmx?qry=Ratis:service=RaftServer,group=*,id=*")
Review Comment:
I forgot to remove it !!
Thanks for the find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891930994
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java:
##########
@@ -80,4 +80,7 @@ public interface SCMMXBean extends ServiceRuntimeInfo {
*/
String getPrimordialNode();
+ String getScmRatisLogDirectory();
+
+ String getScmRocksDbDirectory();
Review Comment:
Thanks for the suggestion !!
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java:
##########
@@ -28,4 +28,9 @@
public interface OMMXBean extends ServiceRuntimeInfo {
String getRpcPort();
+
+ String getOmRatisLogDirectory();
+
+ String getOmRocksDbDirectory();
Review Comment:
Thanks for the suggestion !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ArafatKhan2198 commented on a diff in pull request #3488: HDDS-6840. Add MetaData volume information to the SCM and OM - UI
Posted by GitBox <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r893097645
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -74,6 +74,20 @@ <h2>Status</h2>
</tbody>
</table>
+<h2>Meta-Data Volume Information</h2>
+<table class="table table-bordered table-striped" class="col-md-6">
+ <tbody>
+ <tr>
+ <td>Ratis Directory</td>
+ <td>{{$ctrl.overview.jmx.ScmRatisLogDirectory}}</td>
Review Comment:
Thanks it has been corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3488: HDDS-6840. Add MetaData volume information to the SCM and OM - UI
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #3488:
URL: https://github.com/apache/ozone/pull/3488#issuecomment-1156050142
Merged. Thanks @sadanand48 for the review and @ArafatKhan2198 for contributing the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org