You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/07/07 19:16:01 UTC

Review Request 60715: AMBARI-21421 EU upgrade pack to update Hive and Yarn properties to remove IOP/BigSQL properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60715/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21421
    https://issues.apache.org/jira/browse/AMBARI-21421


Repository: ambari


Description
-------

IOP Yarn has property "" that requires Spark Shuffle Jar. HDP does not have this jar. The property needs to be removed during EU.
BigSQL also inserts a property to hive-site that causes Hive to crash during/post EU due to the unique BigSQL upgrade/migrate process (that requires BigSQL to be removed before EU). This property needs to be removed as well.


Diffs
-----

  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 6597055 
  ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 6597055 
  ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 


Diff: https://reviews.apache.org/r/60715/diff/1/


Testing
-------

integrated tests during EU


Thanks,

Di Li


Re: Review Request 60715: AMBARI-21421 EU upgrade pack to update Hive and Yarn properties to remove IOP/BigSQL properties

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60715/#review180054
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
Lines 38 (patched)
<https://reviews.apache.org/r/60715/#comment255057>

    Should be `<replace ...`
    
    ```
    Caused by: org.xml.sax.SAXParseException; systemId: file:/var/lib/ambari-server/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml; lineNumber: 38; columnNumber: 94; cvc-complex-type.2.4.a: Invalid content was found starting with element 'find'. One of '{transfer, set, replace, regex-replace, insert}' is expected.
    ```



ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
Lines 38 (patched)
<https://reviews.apache.org/r/60715/#comment255058>

    Same as above.



ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
Lines 60 (patched)
<https://reviews.apache.org/r/60715/#comment255061>

    Missing close tag, ie. change to `<transfer ... />`


- Attila Doroszlai


On July 7, 2017, 9:16 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60715/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 9:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21421
>     https://issues.apache.org/jira/browse/AMBARI-21421
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> IOP Yarn has property "" that requires Spark Shuffle Jar. HDP does not have this jar. The property needs to be removed during EU.
> BigSQL also inserts a property to hive-site that causes Hive to crash during/post EU due to the unique BigSQL upgrade/migrate process (that requires BigSQL to be removed before EU). This property needs to be removed as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 6597055 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 6597055 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60715/diff/1/
> 
> 
> Testing
> -------
> 
> integrated tests during EU
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60715: AMBARI-21421 EU upgrade pack to update Hive and Yarn properties to remove IOP/BigSQL properties

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60715/#review179937
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On July 7, 2017, 7:16 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60715/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 7:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21421
>     https://issues.apache.org/jira/browse/AMBARI-21421
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> IOP Yarn has property "" that requires Spark Shuffle Jar. HDP does not have this jar. The property needs to be removed during EU.
> BigSQL also inserts a property to hive-site that causes Hive to crash during/post EU due to the unique BigSQL upgrade/migrate process (that requires BigSQL to be removed before EU). This property needs to be removed as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 6597055 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 6597055 
>   ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60715/diff/1/
> 
> 
> Testing
> -------
> 
> integrated tests during EU
> 
> 
> Thanks,
> 
> Di Li
> 
>