[GitHub] [druid] adarshsanjeev commented on a diff in pull request #12431: Validate select columns for insert statement

[GitBox <gi...@apache.org>]

adarshsanjeev commented on code in PR #12431:
URL: https://github.com/apache/druid/pull/12431#discussion_r858250828


##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java:
##########
@@ -838,6 +843,31 @@ static ParsedNodes create(final SqlNode node) throws ValidationException
       return new ParsedNodes(explain, druidSqlInsert, query, ingestionGranularity);
     }
 
+    private static void validateSelectColumnForIngestion(SqlNode sqlNode) throws ValidationException
+    {
+      if (sqlNode instanceof SqlBasicCall) {
+        // If the sql node is a basic call, it could have select statements as operands.
+        // We need to recursivly check the operands for select statements.
+        SqlBasicCall sqlBasicCall = (SqlBasicCall) sqlNode;
+        for (SqlNode operand : sqlBasicCall.getOperandList()) {
+          validateSelectColumnForIngestion(operand);
+        }
+      } else if (sqlNode instanceof SqlSelect) {
+        // Validate that all columns which do some computation in the select statement are named.
+        // If the column is named, the top level operator should be "AS".
+        for (SqlNode column : ((SqlSelect) sqlNode).getSelectList().getList()) {
+          if (column instanceof SqlBasicCall) {
+            SqlBasicCall basicCall = (SqlBasicCall) column;
+            if (!"AS".equalsIgnoreCase(basicCall.getOperator().getName())) {

Review Comment:
   Yes, Calcite implicitly uses the AS operator in the parse tree in such cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org