You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/22 08:34:48 UTC

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

yhwangBonc commented on a change in pull request #1749:
URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492563096



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java
##########
@@ -52,6 +52,35 @@ public static CompressionType deserialize(short i) {
     }
   }
 
+  /**
+   * give an byte to return a compression type.
+   *
+   * @param i byte number
+   * @return CompressionType
+   */
+  public static CompressionType byteToEnum(byte i) {

Review comment:
       It's my negligence. I'll change it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org