You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/12/05 22:37:39 UTC

Review Request 64355: Fixed a flaky test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64355/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-8288
    https://issues.apache.org/jira/browse/MESOS-8288


Repository: mesos


Description
-------

This fixes SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect
to expect the shutdown to occur at most once, since it's possible
that when the test objects are being destructed, the executor's
shutdown method is not called.


Diffs
-----

  src/tests/slave_tests.cpp eee6aa4cfb607b7c46a6d44e8893649110c1c8da 


Diff: https://reviews.apache.org/r/64355/diff/1/


Testing
-------

Ran in repetition.


Thanks,

Benjamin Mahler

Re: Review Request 64355: Fixed a flaky test.

Posted by Vinod Kone <vi...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64355/#review192942
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 5, 2017, 10:37 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64355/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 10:37 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8288
>     https://issues.apache.org/jira/browse/MESOS-8288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect
> to expect the shutdown to occur at most once, since it's possible
> that when the test objects are being destructed, the executor's
> shutdown method is not called.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp eee6aa4cfb607b7c46a6d44e8893649110c1c8da 
> 
> 
> Diff: https://reviews.apache.org/r/64355/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>