You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@hotwaxmedia.com> on 2014/04/25 07:24:45 UTC
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/
On Apr 24, 2014, at 10:23 PM, jleroux@apache.org wrote:
> <simple-method method-name="issueProductionRunTask" short-description="Issues the Inventory for a Production Run Task" login-required="false">
> <entity-one entity-name="WorkEffort" value-field="workEffort"/>
> @@ -159,7 +174,7 @@ under the License.
> <if>
> <condition>
> <or>
> - <if-empty field="parameters.failIfItemsAreNotOnHand"/>
> + <if-compare field="parameters.failIfItemsAreNotAvailable" operator="equals" value="Y" type="String"/>
> <if-compare field="parameters.failIfItemsAreNotOnHand" operator="equals" value="Y" type="String"/>
> </or>
> </condition>
I suspect this should not be part of the commit.
Jacopo
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing:
config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/
widget/manufacturing/
Posted by Jacques Le Roux <ja...@free.fr>.
Thanks Pierre, it's clear now
Jacques
Le 25/04/2014 23:25, Pierre Smits a écrit :
> I must apologize to you both for you spending your time on OFBIZ-5224.
> Having spend some time the last few days on the context of the issue I came
> to realise that the patch I provided would not be better than the situation
> it tries to alleviate. It would just flip the coin. And that wouldn't be in
> the best interest of this community or the users of the output of this
> project.
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
>
> On Fri, Apr 25, 2014 at 5:50 PM, Jacques Le Roux <ja...@free.fr>wrote:
>
>> OK, makes sense now, would have been easier if Pierre have responded in
>> time
>>
>> Reverted this line at r1590063
>>
>> Jacques
>>
>> Le 25/04/2014 16:39, Jacopo Cappellato a écrit :
>>
>> On Apr 25, 2014, at 2:27 PM, Jacques Le Roux <ja...@free.fr>
>>> wrote:
>>>
>>> This is actually a bug fix and another Jira issue is open for it:
>>>> OFBIZ-5224.
>>>>
>>> I had closed that issue as a Not a Problem: please see my comments there.
>>> That code should be reverted.
>>>
>>> Jacopo
>>>
>>>
>>>
>>>
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing:
config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/
webapp/manufacturing/WEB-INF/ widget/manufacturing/
Posted by Pierre Smits <pi...@gmail.com>.
I must apologize to you both for you spending your time on OFBIZ-5224.
Having spend some time the last few days on the context of the issue I came
to realise that the patch I provided would not be better than the situation
it tries to alleviate. It would just flip the coin. And that wouldn't be in
the best interest of this community or the users of the output of this
project.
Regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Fri, Apr 25, 2014 at 5:50 PM, Jacques Le Roux <ja...@free.fr>wrote:
> OK, makes sense now, would have been easier if Pierre have responded in
> time
>
> Reverted this line at r1590063
>
> Jacques
>
> Le 25/04/2014 16:39, Jacopo Cappellato a écrit :
>
> On Apr 25, 2014, at 2:27 PM, Jacques Le Roux <ja...@free.fr>
>> wrote:
>>
>> This is actually a bug fix and another Jira issue is open for it:
>>> OFBIZ-5224.
>>>
>> I had closed that issue as a Not a Problem: please see my comments there.
>> That code should be reverted.
>>
>> Jacopo
>>
>>
>>
>>
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing:
config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/
widget/manufacturing/
Posted by Jacques Le Roux <ja...@free.fr>.
OK, makes sense now, would have been easier if Pierre have responded in time
Reverted this line at r1590063
Jacques
Le 25/04/2014 16:39, Jacopo Cappellato a écrit :
> On Apr 25, 2014, at 2:27 PM, Jacques Le Roux <ja...@free.fr> wrote:
>
>> This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224.
> I had closed that issue as a Not a Problem: please see my comments there.
> That code should be reverted.
>
> Jacopo
>
>
>
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing: config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/ widget/manufacturing/
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
On Apr 25, 2014, at 2:27 PM, Jacques Le Roux <ja...@free.fr> wrote:
> This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224.
I had closed that issue as a Not a Problem: please see my comments there.
That code should be reverted.
Jacopo
Re: svn commit: r1589869 - in /ofbiz/trunk/applications/manufacturing:
config/ data/ script/org/ofbiz/manufacturing/jobshopmgt/ servicedef/ webapp/manufacturing/WEB-INF/
widget/manufacturing/
Posted by Jacques Le Roux <ja...@free.fr>.
This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224. I guess it slipped in Pierre's OFBIZ-5523 patch. In a sense Pierre is
correct, and I checked the 1st part (simple-methods below) when I reviewed his 1st patch for OFBIZ-5523 some months ago
The simple-method issueProductionRunTaskComponent implements the service of same name which is called by issueProductionRunTask, which correctly sets
<if-empty field="parameters.failIfItemsAreNotOnHand">
<set field="parameters.failIfItemsAreNotOnHand" value="Y"/>
</if-empty>
before calling issueProductionRunTaskComponent
But that's not all the story. Unfortunately, 1st time I did not check another call by updateProductionRunTask Java services, failIfItemsAreNotOnHand
is not set there , so the solution before was correct in this case.
I would revert this change, fixe both issues in another commit and backport and close OFBIZ-5224, but I will wait Pierre's answer OFBIZ-5224 before.
Jacques
Le 25/04/2014 07:24, Jacopo Cappellato a écrit :
> On Apr 24, 2014, at 10:23 PM, jleroux@apache.org wrote:
>
>> <simple-method method-name="issueProductionRunTask" short-description="Issues the Inventory for a Production Run Task" login-required="false">
>> <entity-one entity-name="WorkEffort" value-field="workEffort"/>
>> @@ -159,7 +174,7 @@ under the License.
>> <if>
>> <condition>
>> <or>
>> - <if-empty field="parameters.failIfItemsAreNotOnHand"/>
>> + <if-compare field="parameters.failIfItemsAreNotAvailable" operator="equals" value="Y" type="String"/>
>> <if-compare field="parameters.failIfItemsAreNotOnHand" operator="equals" value="Y" type="String"/>
>> </or>
>> </condition>
> I suspect this should not be part of the commit.
>
> Jacopo
>