You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/19 12:25:28 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4383: Update
committer review and merge guide
kezhenxu94 opened a new pull request #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383
Since we have more and more committers, this patch updates some worth-noted guide when committers are merging pull requests, avoid too many useless commits in Git log, like #4379
@apache/skywalking-committers and future committer @aderm , please take some time to go through the documentation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383#issuecomment-588212701
> @kezhenxu94 Please help on submitting the JIRA ticket to close `Allow merge commits ` and keep `Allow squash merging` only. I am failing to open JIRA site.
https://issues.apache.org/jira/browse/INFRA-19869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383#issuecomment-588202186
> The last PR breaks this, do we need to close another merge option?
I prefer to close other merge options, it seems that we don't have any scenario to merge without squashing so far
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383#issuecomment-588200299
The last PR breaks this, do we need to close another merge option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383#issuecomment-588205234
@kezhenxu94 Please help on submitting the JIRA ticket to close `Allow merge commits ` and keep `Allow squash merging` only. I am failing to open JIRA site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4383: Update committer
review and merge guide
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4383: Update committer review and merge guide
URL: https://github.com/apache/skywalking/pull/4383#issuecomment-588202768
We lost the 208th contributor metrics because of that merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services