You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "rkannan (via GitHub)" <gi...@apache.org> on 2024/12/31 12:42:38 UTC

[I] [C++] compilation standard to C++20 [arrow]

rkannan opened a new issue, #44792:
URL: https://github.com/apache/arrow/issues/44792

   ### Describe the enhancement requested
   
   are there any issues with setting the default to c++20 in the codebase? Currently the cmake_modules/SetupCxxFlags.cmake sets CMAKE_CXX_STANDARD to 17. 
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #44792: [C++] compilation standard to C++20
URL: https://github.com/apache/arrow/issues/44792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2566801411

   > I think before such a move we should properly document our support policy.
   
   It mentions supported GCC/Clang/MSVC versions explicitly, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2566418430

   We can use C++20 with GCC 8 or later: https://gcc.gnu.org/projects/cxx-status.html#cxx20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2486690147

   Yes that's not a quick decision to make. Here is the thread about bumping to 17 2 years ago: https://lists.apache.org/thread/9g14n3odhj6kzsgjxr6k6d3q73hg2njr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2486880659

   I checked and we currently can't switch to 20 because CRAN (R package hub) has several builds with AppleClang <=14. This is a blocker but not necessarily the only one.
   
   You are certainly not alone in preferring to use C++20 but as arrow C++ is a foundational library we have to be more conservative with such thinks.
   
   I will close this issue for now, we can re-visted in time 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2508934957

   It seems that "Apple Clang 1300.0.29.30" is the oldest version based on the last R arrow package check information:
   
   * https://cran.r-project.org/web/checks/check_results_arrow.html
   * https://cran.r-project.org/web/checks/check_flavors.html#r-oldrel-macos-x86_64
   
   It's based on LLVM 12.0.0. See also: https://en.wikipedia.org/wiki/Xcode#Xcode_11.0_-_14.x_(since_SwiftUI_framework)_2
   
   LLVM 12.0.0 has `-std=c++20`. See also: https://clang.llvm.org/cxx_status.html#cxx20
   
   So we may be able to use C++20 on CRAM. (We may not be able to use some C++20 features.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser closed issue #44792: [C++] compilation standard to C++20
URL: https://github.com/apache/arrow/issues/44792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2642397227

   Thanks for pointing me to this issue @kou 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2566825046

   AFAIK this is the only place we mention it:
   >A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be sufficient. For Windows, at least Visual Studio VS2017 is required.
   
   https://arrow.apache.org/docs/developers/cpp/building.html
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2642396815

   FYI: We tried C++20: #45445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2566526453

   I think before such a move we should properly document our support policy. That will create clarity both for users and contributors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-2566903758

   It seems that we need to add only Clang version to the document.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-4406136322

   This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] compilation standard to C++20 [arrow]

Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on issue #44792:
URL: https://github.com/apache/arrow/issues/44792#issuecomment-4779123682

   We now compile to C++20, see https://github.com/apache/arrow/issues/48587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org