[GitHub] [ignite-3] valepakh commented on a diff in pull request #1931: IGNITE-19021 Support the directory deployment

["valepakh (via GitHub)" <gi...@apache.org>]

valepakh commented on code in PR #1931:
URL: https://github.com/apache/ignite-3/pull/1931#discussion_r1172340243


##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/deployment/DeploymentManagementController.java:
##########
@@ -123,4 +100,11 @@ public static UnitStatus fromUnitStatus(org.apache.ignite.internal.deployunit.Un
         }
         return new UnitStatus(status.id(), versionToDeploymentStatus);
     }
+
+    private static Version parseVersion(String unitVersion) {
+        if (unitVersion == null || unitVersion.isBlank()) {

Review Comment:
   I tink the idea was that this logic (latest version by default) applies only to the REST API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org