You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by br...@apache.org on 2013/07/30 20:44:27 UTC
git commit: Fixed comment for Hadoop pending tasks calculation.
Updated Branches:
refs/heads/master 0047bd40d -> aa2c15d10
Fixed comment for Hadoop pending tasks calculation.
The commit 58e6c907497418d was submitted prematurely without this
comment.
Review: https://reviews.apache.org/r/12959
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/aa2c15d1
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/aa2c15d1
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/aa2c15d1
Branch: refs/heads/master
Commit: aa2c15d10d2f59f9b0c5421fd695ccf83db7a6f4
Parents: 0047bd4
Author: Brenden Matthews <br...@airbnb.com>
Authored: Thu Jul 25 16:13:49 2013 -0700
Committer: Brenden Matthews <br...@airbnb.com>
Committed: Tue Jul 30 11:44:12 2013 -0700
----------------------------------------------------------------------
.../src/java/org/apache/hadoop/mapred/MesosScheduler.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/aa2c15d1/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
----------------------------------------------------------------------
diff --git a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
index d9a9dbb..0c10874 100644
--- a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
+++ b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
@@ -273,10 +273,11 @@ public class MesosScheduler extends TaskScheduler implements Scheduler {
}
// For some reason, pendingMaps() and pendingReduces() doesn't return the
- // actual number we're looking for (presumably for some legacy
- // backward-compat reasons). Below is the algorithm that is used to
- // calculate the pending tasks within the Hadoop JobTracker sources (see
- // 'printTaskSummary' in src/org/apache/hadoop/mapred/jobdetails_jsp.java).
+ // values we expect. We observed negative values, which may be related to
+ // https://issues.apache.org/jira/browse/MAPREDUCE-1238. Below is the
+ // algorithm that is used to calculate the pending tasks within the Hadoop
+ // JobTracker sources (see 'printTaskSummary' in
+ // src/org/apache/hadoop/mapred/jobdetails_jsp.java).
private int getPendingTasks(TaskInProgress[] tasks) {
int totalTasks = tasks.length;
int runningTasks = 0;