You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2011/02/18 08:59:11 UTC
[jira] Created: (DERBY-5055) [patch] add visibility to static
method calls
[patch] add visibility to static method calls
---------------------------------------------
Key: DERBY-5055
URL: https://issues.apache.org/jira/browse/DERBY-5055
Project: Derby
Issue Type: Improvement
Components: Network Server
Affects Versions: 10.7.1.1
Reporter: Dave Brosius
Priority: Trivial
Fix For: 11.0.0.0
code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996446#comment-12996446 ]
Lily Wei commented on DERBY-5055:
---------------------------------
Wow! You are finding a lot of code that can be improve consistently. Awesome. Do you use any tool to help your finding?
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated DERBY-5055:
--------------------------------
Attachment: static_visibility.diff
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-5055) [patch] add visibility to static method
calls
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius closed DERBY-5055.
-------------------------------
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0, 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997213#comment-12997213 ]
Lily Wei commented on DERBY-5055:
---------------------------------
Thanks, Dave. Suites.all and derbyall run clean. If there is no object, I will commit the change.
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997249#comment-12997249 ]
Lily Wei commented on DERBY-5055:
---------------------------------
Thanks Dave for contribute the patch. Thanks Knut for reviewing it. I've committed with revision 1072817.
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997221#comment-12997221 ]
Knut Anders Hatlen commented on DERBY-5055:
-------------------------------------------
The patch looks fine to me. +1 to commit.
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Lily Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lily Wei resolved DERBY-5055.
-----------------------------
Resolution: Fixed
Fix Version/s: 10.8.0.0
Assignee: Dave Brosius
Bug behavior facts: [Performance]
Issue & fix info: [Patch Available]
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0, 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by Kathey Marsden <km...@sbcglobal.net>.
On 2/18/2011 8:43 AM, Dave Brosius (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996506#comment-12996506 ]
>
> Dave Brosius commented on DERBY-5055:
> -------------------------------------
>
> some of them are findbugs, others are found just by code inspection, after looking at 'unrelated' findbugs results.
>
>> [patch] add visibility to static method calls
>> ---------------------------------------------
>>
>> Key: DERBY-5055
>> URL: https://issues.apache.org/jira/browse/DERBY-5055
>> Project: Derby
>> Issue Type: Improvement
>> Components: Network Server
>> Affects Versions: 10.7.1.1
>> Reporter: Dave Brosius
>> Priority: Trivial
>> Fix For: 11.0.0.0
>>
>> Attachments: static_visibility.diff
>>
>> Original Estimate: 1h
>> Remaining Estimate: 1h
>>
>> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
Thank you Dave for all the great fixes and welcome to the Derby
community! Thank you Knut for picking up all those patches!
We recently heard from Cesar Couto asking if we used findbugs:
http://old.nabble.com/Do-Derby-developers-use-FindBugs--ts30762542.html#a30762542
I'll cc him on this thread in case he is not subscribed to the list. I
am sure he would be interested in your findbugs findings for his research.
Kathey
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996506#comment-12996506 ]
Dave Brosius commented on DERBY-5055:
-------------------------------------
some of them are findbugs, others are found just by code inspection, after looking at 'unrelated' findbugs results.
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-5055) [patch] add visibility to static
method calls
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996530#comment-12996530 ]
Kathey Marsden commented on DERBY-5055:
---------------------------------------
Thank you Dave for all the great fixes and welcome to the Derby
community! Thank you Knut for picking up all those patches!
We recently heard from Cesar Couto asking if we used findbugs:
http://old.nabble.com/Do-Derby-developers-use-FindBugs--ts30762542.html#a30762542
I'll cc him on this thread in case he is not subscribed to the list. I
am sure he would be interested in your findbugs findings for his research.
Kathey
> [patch] add visibility to static method calls
> ---------------------------------------------
>
> Key: DERBY-5055
> URL: https://issues.apache.org/jira/browse/DERBY-5055
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 11.0.0.0
>
> Attachments: static_visibility.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code in various spots calls static method calls thru instance variables. Patch brings visibitity to these calls by calling thru static class. This exposes areas where code can be removed (fetching the now unused instance variable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira