You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/12 01:38:29 UTC
[GitHub] [pulsar-site] tisonkun opened a new pull request, #250: trim more i18n content
tisonkun opened a new pull request, #250:
URL: https://github.com/apache/pulsar-site/pull/250
cc @urfreespace
Also, please help check if `site2/website-next/scripts/write-redirect.js` still valid or we can simplify the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #250: trim more i18n content
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #250:
URL: https://github.com/apache/pulsar-site/pull/250#discussion_r992903882
##########
site2/tools/publish-website.sh:
##########
@@ -57,17 +57,11 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
echo "clean all the old content"
find $PULSAR_SITE_TMP/content -print \
| grep -v $PULSAR_SITE_TMP/content$ \
- | grep -v $PULSAR_SITE_TMP/content/zh-CN \
- | grep -v $PULSAR_SITE_TMP/content/zh-TW \
- | grep -v $PULSAR_SITE_TMP/content/ja \
- | grep -v $PULSAR_SITE_TMP/content/ko \
- | grep -v $PULSAR_SITE_TMP/content/fr \
| grep -v $PULSAR_SITE_TMP/content/api \
| grep -v $PULSAR_SITE_TMP/content/charts \
| grep -v $PULSAR_SITE_TMP/content/css \
| grep -v $PULSAR_SITE_TMP/content/tools \
| grep -v $PULSAR_SITE_TMP/content/reference \
- | grep -v $PULSAR_SITE_TMP/content/charts \
Review Comment:
Duplicate to original L66.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #250: trim more i18n content
Posted by GitBox <gi...@apache.org>.
urfreespace merged PR #250:
URL: https://github.com/apache/pulsar-site/pull/250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #250: trim more i18n content
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #250:
URL: https://github.com/apache/pulsar-site/pull/250#discussion_r992903749
##########
.github/workflows/ci-pulsar-website-next-build.yaml:
##########
@@ -105,6 +105,5 @@ jobs:
CROWDIN_PERSONAL_TOKEN: ${{ secrets.NEXT_CROWDIN_DOCUSAURUS_API_TOKEN }}
run: |
echo "Building Website"
- sed -i "s#CROWDIN_PERSONAL_TOKEN#$CROWDIN_PERSONAL_TOKEN#g" site2/website-next/crowdin.yml
Review Comment:
This line causes build to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #250: trim more i18n content
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #250:
URL: https://github.com/apache/pulsar-site/pull/250#discussion_r992904080
##########
site2/tools/publish-website.sh:
##########
@@ -57,17 +57,11 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
echo "clean all the old content"
find $PULSAR_SITE_TMP/content -print \
| grep -v $PULSAR_SITE_TMP/content$ \
- | grep -v $PULSAR_SITE_TMP/content/zh-CN \
- | grep -v $PULSAR_SITE_TMP/content/zh-TW \
- | grep -v $PULSAR_SITE_TMP/content/ja \
- | grep -v $PULSAR_SITE_TMP/content/ko \
- | grep -v $PULSAR_SITE_TMP/content/fr \
Review Comment:
No longer used generated content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org