[GitHub] pengzhao-intel commented on a change in pull request #12069: [Flaky Test] Fix test_gluon_model_zoo.test_models when MXNET_MKLDNN_DEBUG=1

[GitBox <gi...@apache.org>]

pengzhao-intel commented on a change in pull request #12069: [Flaky Test] Fix test_gluon_model_zoo.test_models when MXNET_MKLDNN_DEBUG=1 
URL: https://github.com/apache/incubator-mxnet/pull/12069#discussion_r209179107
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_base.cc
 ##########
 @@ -496,11 +496,8 @@ void OpCheck::Run(mxnet::FCompute fn, const nnvm::NodeAttrs &attrs,
                   const std::vector<mxnet::NDArray> &inputs_,
                   const std::vector<mxnet::OpReqType> &req,
                   const std::vector<mxnet::NDArray> &outputs_) {
-
   static auto& is_excluded = Op::GetAttr<bool>("TExcludeMKLDNNDebug");
-
   if (is_excluded.get(attrs.op, false)) return;
-
 
 Review comment:
   Could we give a warning that the OP is not checked?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services